1851121 - [wpt-sync] Sync PR 41756 - [fetch-later] Limit max amount of deferred requests per origin

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41756 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41756
Details from upstream follow.

Ming-Ying Chung <[e-mail]> wrote:

[fetch-later] Limit max amount of deferred requests per origin

The spec of the "Deferred fetching" algorithm sets the maximum
bytes of deferred requests (a fetchLater request) for a request URL
origin to 64 kilobytes.

This CL implements the restriction by surfacing a fetch's Request
body size from Request::ExtractBody() to
FetchRequestData::BufferByteLength(). The body size is extraced from
v8 value when ExtractBody() performs the body extraction.

Intentionally not to modify Body (Requests's base class) nor
BodyStreamBuffer (FetchRequestData::Buffer()'s return type), as they
are all widely used beyond a request (it can be a response body).

Bug: 1465781
Change-Id: I075be5043f5658971d347729923f968b428bc7c1
Reviewed-on: https://chromium-review.googlesource.com/4835437
WPT-Export-Revision: 3e10be6914b1d87bb4138be470166e4a5701b009

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f24a4237e62b02f4ccb31a2854142462f9484f5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests and 20 subtests

Status Summary

Firefox

ERROR: 11

Chrome

OK : 7
PASS : 69
ERROR: 4

Safari

ERROR: 11

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fetch/fetch-later/quota.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /fetch/fetch-later/send-on-discard.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending-beacon/pending_beacon-basic.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /pending-beacon/pending_beacon-deactivate.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /pending-beacon/pending_beacon-sendnow.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /pending-beacon/pending_beacon-sendondiscard.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending-beacon/pending_beacon-sendonhidden.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /pending-beacon/pending_get_beacon-cors.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /pending-beacon/pending_get_beacon-send.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /pending-beacon/pending_post_beacon-cors.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /pending-beacon/pending_post_beacon-sendwithdata.tentative.https.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae7eac085a26
[wpt PR 41756] - [fetch-later] Limit max amount of deferred requests per origin, a=testonly
https://hg.mozilla.org/integration/autoland/rev/826a2adb5aff
[wpt PR 41756] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ae7eac085a26
https://hg.mozilla.org/mozilla-central/rev/826a2adb5aff