1851191 - expired variants fail to expire if they are a composite variant

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we had some variants expire aab, webgl-ipc, etc...

the webgl-ipc expired, but the aab-nofis tasks still run. This is because of the logic here:

        for name in variants:
            parts = [p for p in name.split("+") if p not in expired]
            if len(parts) == 0:
                continue

we need to continue IF we find a variant, not if anything remains after removing the variant from the list.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1851191 - expire variants even if they are composite variants. r=suhaib!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca7f848c07fe
expire variants even if they are composite variants. r=suhaib,taskgraph-reviewers,gbrown

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ca7f848c07fe