Prefix all Application Services dependency name constants with `mozilla_appservices`
Categories
(Firefox for Android :: General, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox119 | --- | fixed |
People
(Reporter: lina, Assigned: jackyzy823, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Android Components depends on several packages in Application Services. These are all listed in the DependenciesPlugin.kt file; any dependency that mentions ApplicationServicesConfig is an Application Services package.
We currently use the mozilla_ prefix for all of them, which makes it a little difficult to tell at first glance that it's an Application Services dependency. Some of them are also named slightly differently than the package. For example, mozilla_sync_autofill and mozilla_sync_logins have "sync" in the name, even though the Application Services package name doesn't, and mozilla_remote_tabs is just tabs.
For easier scanning—and grepping—let's rename these constants!
- Let's prefix all Application Services dependencies with
mozilla_appservices. Somozilla_nimbuswould becomemozilla_appservices_nimbus;mozilla_placeswould becomemozilla_appservices_places, and so on. - Let's drop any extraneous words from the constant names. So
mozilla_sync_autofillwould becomemozilla_appservices_autofill;mozilla_remote_tabswould becomemozilla_appservices_tabs, and so on. - Finally, let's make sure that the constant matches the package name. So
mozilla_fxawould becomemozilla_appservices_fxaclient;mozilla_sync_managerwould becomemozilla_appservices_syncmanager, and so on.
After renaming these constants in DependenciesPlugin.kt, we'll need to make sure to update all build.gradle files that reference them, too. This is a great first bug for getting started with Android and Kotlin development, and learning about Android Studio's refactoring tools!
Comment 1•2 years ago
|
||
| Reporter | ||
Updated•2 years ago
|
Comment 2•2 years ago
|
||
Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/6d9625997c40cb2dd68e031a94036dc2db54008b
[main] Bug 1851213 - Prefix Application Services dependency
Updated•2 years ago
|
Description
•