Closed Bug 1851213 Opened 2 years ago Closed 2 years ago

Prefix all Application Services dependency name constants with `mozilla_appservices`

Categories

(Firefox for Android :: General, task)

All
Android
task

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: lina, Assigned: jackyzy823, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Android Components depends on several packages in Application Services. These are all listed in the DependenciesPlugin.kt file; any dependency that mentions ApplicationServicesConfig is an Application Services package.

We currently use the mozilla_ prefix for all of them, which makes it a little difficult to tell at first glance that it's an Application Services dependency. Some of them are also named slightly differently than the package. For example, mozilla_sync_autofill and mozilla_sync_logins have "sync" in the name, even though the Application Services package name doesn't, and mozilla_remote_tabs is just tabs.

For easier scanning—and grepping—let's rename these constants!

  • Let's prefix all Application Services dependencies with mozilla_appservices. So mozilla_nimbus would become mozilla_appservices_nimbus; mozilla_places would become mozilla_appservices_places, and so on.
  • Let's drop any extraneous words from the constant names. So mozilla_sync_autofill would become mozilla_appservices_autofill; mozilla_remote_tabs would become mozilla_appservices_tabs, and so on.
  • Finally, let's make sure that the constant matches the package name. So mozilla_fxa would become mozilla_appservices_fxaclient; mozilla_sync_manager would become mozilla_appservices_syncmanager, and so on.

After renaming these constants in DependenciesPlugin.kt, we'll need to make sure to update all build.gradle files that reference them, too. This is a great first bug for getting started with Android and Kotlin development, and learning about Android Studio's refactoring tools!

Assignee: nobody → jackyzy823
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: