1851398 - testserver.pl fails if SSL certificate is self-signed

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Dave Miller [:justdave]]

What it says on the tin. If you have a self-signed certificate (for example, on a testing server), then testserver.pl mysteriously fails, even if your server is otherwise working fine.

Comment 1

[Dave Miller [:justdave]]

Attachment: patch for 5.2

• Shows the error that was returned in the output when a fetch fails, instead of just failing.
• If the error is a certificate error, output a suggestion to pass the --self-signed flag
• Adds a --self-signed flag that turns off certificate checks.

Comment 2

[Nicolás Aragone [:juest]]

originally proposed on chat by me, LGTM

Comment 3

[Dave Miller [:justdave]]

Attachment: patch for 5.2

Oops, say needs an argument, even if it's empty.

Comment 4

[Dave Miller [:justdave]]

Attachment: GitHub Pull Request for 5.2

Comment 5

[Dave Miller [:justdave]]

Attachment: GitHub Pull Request for harmony

Comment 6

[Frédéric Buclin]

Isn't this a duplicate of bug 662161, which has been commited in 5.1.x ?

Comment 7

[Dave Miller [:justdave]]

(In reply to Frédéric Buclin from comment #6)

Isn't this a duplicate of bug 662161, which has been commited in 5.1.x ?

No, that actually seems to be fixing a different problem... which should also be fixed here probably.

That one is fixing a problem where it won't work with https at all. This one is fixing where it knows https but doesn't like the certificate.

And it seems you can't run into bug 662161's situation on Ubuntu if using packaged Perl modules as the LWP package for Ubuntu requires LWP::Protocol::https as a dependency for LWP.

But RHEL/CentOS does not.

Comment 8

[Dave Miller [:justdave]]

I pulled in the check for LWP::Protocol::https from bug 662161 as requested in the bugzilla bug for this on both PRs, needs a re-review (requested on GH)

Comment 9

[Dave Miller [:justdave]]

5.2: https://github.com/bugzilla/bugzilla/commit/1f5bf06c3c55b3ba75b5aeca5c1b81d0cf9cd42c
Harmony: https://github.com/bugzilla/harmony/commit/a171b3ca5eaea1e271095d0a082e84ca670ba935