1851414 - <a> and <area>'s search setter should use the UTF-8 URL encoding

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Anne (:annevk)]

I'm fixing the relevant WPT test in https://github.com/web-platform-tests/wpt/pull/41785.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Should be easy to fix.
We just need to use SetQuery instead of SetQueryWithEncoding here

Comment 2

[Anne (:annevk)]

You should also be able to remove SetQueryWithEncoding: https://github.com/whatwg/url/issues/783.

Comment 3

[Masatoshi Kimura [:emk]]

Is it web compatible? <a>/<area> href setter still consider the page encoding at least on Chrome.

Comment 4

[Simon Pieters [:zcorpan]]

The test passes in Chrome and Safari: https://wpt.fyi/results/html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html%3Finclude%3Dhyperlink-search?label=experimental&label=master&aligned

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to Simon Pieters [:zcorpan] from comment #4)

The test passes in Chrome and Safari: https://wpt.fyi/results/html/infrastructure/urls/resolving-urls/query-encoding/windows-1252.html%3Finclude%3Dhyperlink-search?label=experimental&label=master&aligned

It is <a>/<area>.search, not <a>/<area>.href.

Comment 6

[Masatoshi Kimura [:emk]]

Ah, I misread the bug title, sorry. This bug is not about href setter.

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1851414 - <a> and <area>'s search setter should use the UTF-8 URL encoding r=#necko

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a82772ba143
<a> and <area>'s search setter should use the UTF-8 URL encoding r=necko-reviewers,kershaw

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3a82772ba143