1851535 - Dead code removal

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Code coverage data has revealed some chunks of dead code. Unsurprising given how much we've rebuilt in the past few years. I'll use this bug to remove the dead code as I find it. This will probably be an ongoing effort for a number of months.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove AddrBookUtils.SimpleEnumerator. r=#thunderbird-reviewers

This has been obsolete since we changed address book interfaces to use arrays instead of enumerators.

Comment 2

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove extended thread tree column picker. r=#thunderbird-reviewers

This is the column picker that allowed applying the selected columns to other folders. It has been obsolete since we replaced the mail tabs.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a2cc373dc907
Remove AddrBookUtils.SimpleEnumerator. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove folderPane.getFolderFromUri. r=#thunderbird-reviewers

This is unused. And a bit weird.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/953dc48bb0a5
Remove folderPane.getFolderFromUri. r=aleca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ea706048fb7
Remove extended thread tree column picker. r=mkmelin

Comment 7

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove code for displaying message headers as a separate document. r=#thunderbird-reviewers

This is a very old way we used to display the message headers.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8e4ced19d6fd
Remove code for displaying message headers as a separate document. r=mkmelin

Comment 9

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove nsMimeStringEnumerator. r=#thunderbird-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/80fb83e14dff
Remove nsMimeStringEnumerator. r=leftmostcat

Comment 11

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead code from threadPane.js. r=#thunderbird-reviewers

This code was for the old mail tabs and is no longer used.

Depends on D189336

Comment 12

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead code from folderDisplay.js. r=#thunderbird-reviewers

This code was for the old mail tabs and is no longer used.

Depends on D189338

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ab752e718de
Remove dead code from threadPane.js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/b446a820170d
Remove dead code from folderDisplay.js. r=mkmelin

Comment 14

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead code in nsMsgProtocol. r=#thunderbird-reviewers

This hasn't been used since the C++ implementations of SMTP, POP3 and NNTP were removed.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/13c7f8f0760e
Remove dead code in nsMsgProtocol. r=mkmelin

Comment 16

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove the defunct add-on preferences menu code. r=#thunderbird-reviewers

This is code for a piece of UI that no longer exists.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2d4f49ffb86f
Remove the defunct add-on preferences menu code. r=mkmelin

Comment 18

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead function getWindowsVersionInfo. r=#thunderbird-reviewers

This hasn't been used since bug 1844734.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b5513d44776d
Remove dead function getWindowsVersionInfo. r=thunderbird-reviewers,leftmostcat,ikey

Comment 20

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead function tabmail.getBrowserForDocumentId. r=#thunderbird-reviewers

This hasn't been used since bug 1691304.

Comment 21

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove migrations for profiles last used before Thunderbird 91. r=#thunderbird-reviewers

This code has been present in at least three ESRs. If a user has a profile that has not been
opened by any of those ESRs, they really should start a fresh profile.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e4edc08897d
Remove dead function tabmail.getBrowserForDocumentId. r=aleca

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6d9221a522ab
Remove migrations for profiles last used before Thunderbird 91. r=aleca

Comment 24

[Francesco]

(In reply to Geoff Lankow (:darktrojan) from comment #21)

If a user has a profile that has not been opened by any of those ESRs, they really should start a fresh profile.

Can you start TB on such an old profile? It doesn't show in the profile manager and in about:profiles, TB doesn't start, it shows a message or it silently malfunctions?

Comment 25

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead newsgroup classes. r=#thunderbird-reviewers

Neither of these have been used since NNTP was ported to JS. DownloadMatchingNewsArticlesToNewsDB wasn't in use before then.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d2729cf6b0ff
Remove dead newsgroup classes. r=mkmelin

Comment 27

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead `tabGetSender` from extensions code. r=#thunderbird-reviewers

Port of https://hg.mozilla.org/mozilla-central/rev/2dc4f1baccc82806eb203617b0184fa634fea3e5

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b2b5c4d2e2dd
Remove dead tabGetSender from extensions code. r=mkmelin

Comment 29

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead arguments for switching LDAP versions. r=#thunderbird-reviewers

LDAP version 3 has been defined as RFC4511 since 2006, and even if people were trying to use
version 2, Thunderbird stopped supporting it in v102.

Comment 30

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead arguments for switching LDAP versions. r=#thunderbird-reviewers

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dba89abce93
Remove dead arguments for switching LDAP versions. r=mkaply

Comment 32

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Bad bot.

Comment 33

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove "find" button from LDAP address book properties dialog. r=#thunderbird-reviewers

I don't know what this button is supposed to do. Whatever it is, it doesn't do it, as there is no code connected.

Comment 34

[Phabricator Automation]

Comment on attachment 9400859 [details]
Bug 1851535 - Remove "find" button from LDAP address book properties dialog. r=#thunderbird-reviewers

Revision D209901 was moved to bug 1895826. Setting attachment 9400859 [details] to obsolete.

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a7b7bf5cdc8
Remove dead arguments for switching LDAP versions. r=aleca

Comment 36

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/0dba89abce93

Comment 37

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead ways of using nsIImportModule. r=#thunderbird-reviewers

We haven't used this code in production since the import UI was rebuilt in Thunderbird 102.

Comment 38

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Change importer tests to use the same code path as about:import does. r=#thunderbird-reviewers

These tests have been importing contacts using XPCOM to find an importer, then using it to do the
importing. Thunderbird doesn't actually import contacts in that way – it uses AddrBookFileImporter,
so the tests should do that too. The importers are dead code.

Comment 39

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead file importers and some other dead importer code. r=#thunderbird-reviewers

These files aren't used by any Thunderbird code.

Comment 40

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove nsIImportFieldMap. r=#thunderbird-reviewers

This code hasn't been used since we replaced the CSV address book importer, except for adding
fields to imported Outlook contacts, and it's unclear to me whether that was even working.

Comment 41

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove sample import data and status functions. r=#thunderbird-reviewers

These methods are unused.

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3ac459a7c73
Remove dead ways of using nsIImportModule. r=aleca

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0c441788076
Change importer tests to use the same code path as about:import does. r=mkmelin

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7136ad65c95e
Remove dead file importers and some other dead importer code. r=mkmelin
https://hg.mozilla.org/comm-central/rev/7e8191c19dd7
Remove nsIImportFieldMap. r=mkmelin
https://hg.mozilla.org/comm-central/rev/098945fb644a
Remove sample import data and status functions. r=mkmelin

Comment 45

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove MsgHdrSyntheticView. r=#thunderbird-reviewers

We stopped using this with the mail tabs rebuild.

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/05f46934f85d
Remove MsgHdrSyntheticView. r=aleca

Comment 47

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove old profile migration code. r=#thunderbird-reviewers

The migration UI that used this code was removed in bug 1867860, and hasn't worked since 91,
according to the commit message on that bug.

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd9b97a055bd
Remove old profile migration code. r=aleca

Comment 49

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove dead code for converting nsIAbCard to XML. r=#thunderbird-reviewers

We used to use this code when printing address books. We don't do it that way any more.

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/259d410e369e
Remove dead code for converting nsIAbCard to XML. r=mkmelin

Comment 51

[Toby Pilling [:tobyp]]

Attachment: Bug 1851535 - Test blocking reviewer on security changes r=aleca

Comment 52

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: Bug 1851535 - Remove MessengerProfileMigrator. r=#thunderbird-reviewers

Comment 53

[Phabricator Automation]

Comment on attachment 9406574 [details]
Bug 1851535 - Remove MessengerProfileMigrator. r=#thunderbird-reviewers

Revision D213187 was moved to bug 1901705. Setting attachment 9406574 [details] to obsolete.

Comment 54

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Retiring this bug now that 128 has branched.