1851536 - Improve code coverage by implementing new tests

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

I'll use this bug to create tests for sections of code that aren't already covered by tests.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test the UI for exporting an address book. r=mkmelin

Includes some rearranging and tidy-up of address book test code.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Fix and test printing in the Address Book tab. r=#thunderbird-reviewers

This fixes a problem where the print preview does not show on the first attempt, then tests that printing works as expected.

Depends on D187419

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f58a18657d70
Test the UI for exporting an address book. r=mkmelin
https://hg.mozilla.org/comm-central/rev/2797148e1ef6
Fix and test printing in the Address Book tab. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test items on the folder pane context menu, part 1. r=#thunderbird-reviewers

Tests for:

• Open in New Tab
• Open in New Window
• New Folder
• Rename
• Delete
• Properties
• Settings

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d535b5a27e31
Test items on the folder pane context menu, part 1. r=mkmelin

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test the subscribe dialog for IMAP and NNTP. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce74ecec0108
Test the subscribe dialog for IMAP and NNTP. r=aleca

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test the Search Messages dialog. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f73f8590b876
Test the Search Messages dialog. r=mkmelin

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9355256 [details]
Bug 1851536 - Test the Search Messages dialog. r=#thunderbird-reviewers

[Triage Comment]
Just taking this patch as a dependency for 1847658

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 115.3.2:
https://hg.mozilla.org/releases/comm-esr115/rev/335cc422a143

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test items on the folder pane context menu, part 2. r=#thunderbird-reviewers

Tests "Mark Folder Read" and "Mark All Folders Read".

Depends on D192291

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Add newsgroups to browser_folderPaneContext.js. r=#thunderbird-reviewers

Depends on D192293

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f9780411b518
Test items on the folder pane context menu, part 2. r=mkmelin

Comment 15

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Move test IMAP and NNTP servers into modules. r=#thunderbird-reviewers

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc6ea3ba10f5
Add newsgroups to browser_folderPaneContext.js. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/70c5614ae55a
Move test IMAP and NNTP servers into modules. r=freaktechnik

Comment 17

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test items on the folder pane context menu, part 3. r=#thunderbird-reviewers

Tests the Empty Trash and Empty Junk items.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f1f04935b91f
Test items on the folder pane context menu, part 3. r=john.bieling

Comment 19

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test dragging messages around about:3pane. r=#thunderbird-reviewers

This tests dragging messages from one folder to another, dragging messages in from the file system and out to the file system.

Comment 20

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Fix and test dragging contacts from the Address Book to the file system. r=#thunderbird-reviewers

I've fixed the behaviour so that multiple contacts can be dragged to the file system on all platforms.

Depends on D193761

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3be0da03bd71
Test dragging messages around about:3pane. r=mkmelin
https://hg.mozilla.org/comm-central/rev/d6be3f51dd37
Fix and test dragging contacts from the Address Book to the file system. r=mkmelin

Comment 22

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test the quota status bar panel and the folder properties dialog quota tab. r=#thunderbird-reviewers

This includes an incomplete implementation of RFC 2087 for the IMAP fakeserver, and resurrecting a long-dead
function in nsImapIncomingServer which should make future tests involving IMAP a bit easier to write.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad171a374390
Test the quota status bar panel and the folder properties dialog quota tab. r=mkmelin

Comment 24

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 follow-up - Wait for IMAP connection to become idle before cleaning up. r=#thunderbird-reviewers

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b1a9f69a791d
follow-up - Wait for IMAP connection to become idle before cleaning up. r=mkmelin

Comment 26

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test setting and clearing tags on messages. r=#thunderbird-reviewers

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e7f972b4211
Test setting and clearing tags on messages. r=mkmelin

Comment 28

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test items on the mail context menu, part 1. r=#thunderbird-reviewers

This adds a test for items related to the content of the message being displayed, and cleans up a few things.

Comment 29

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test items on the mail context menu, part 2. r=#thunderbird-reviewers

This tests items on the menu that open a compose window.

Comment 30

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test items on the mail context menu, part 3. r=#thunderbird-reviewers

This tests items on the menu that only apply when opened from the thread tree.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3f9918a43a42
Test items on the mail context menu, part 1. r=aleca
https://hg.mozilla.org/comm-central/rev/a71a2e4cd1a2
Test items on the mail context menu, part 2. r=aleca
https://hg.mozilla.org/comm-central/rev/60a9947d727b
Test items on the mail context menu, part 3. r=aleca

Comment 32

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Unit test GuessConfig with plain-text servers. r=freaktechnik

This is the first of at least two patches testing GuessConfig.
In this patch I'll test only plain-text connections to servers.
Future patches will test full TLS connections and hopefully startTLS connections.

Comment 33

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Unit test GuessConfig with TLS servers. r=freaktechnik

Depends on D196264

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc1f70df6bf4
Unit test GuessConfig with plain-text servers. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/2febe348ee47
Unit test GuessConfig with TLS servers. r=freaktechnik

Comment 35

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Unit test GuessConfig with invalid TLS servers. r=#thunderbird-reviewers

This improves the earlier TLS tests by giving them valid TLS certificates, based on test
certificate authorities which are loaded at the start of the test. This means we can test TLS
servers without relying on overriding invalid certificates, and that means we can properly test
invalid certificates.

We can now check that (with the appropriate preference set) GuessConfig will return details of
servers with expired or untrusted certificates, and that it won't return details of servers with
certificates that don't match the server domain.

Comment 36

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Unit test GuessConfig returns servers with known subdomains. r=#thunderbird-reviewers

This tests that GuessConfig prefers imap.domain.tld, pop3.domain.tld and smtp.domain.tld over
just domain.tld if there are valid servers at those hostnames.

Depends on D198134

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/512568516a7e
Unit test GuessConfig with invalid TLS servers. r=mkmelin
https://hg.mozilla.org/comm-central/rev/196ee4b3660b
Unit test GuessConfig returns servers with known subdomains. r=mkmelin

Comment 38

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Improve unit testing of FetchConfig. r=#thunderbird-reviewers

Comment 39

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Unit test GuessConfig with startTLS servers. r=#thunderbird-reviewers

Although our test servers don't support startTLS, we can make them do enough to test GuessConfig finds them.

Comment 40

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Refactor test server and certificates handling. r=#thunderbird-reviewers

Depends on D198921

Comment 41

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Add tests for verifyConfig. r=#thunderbird-reviewers

Tests a correct configuration and several incorrect configurations. There are many more failure
cases to add, but this is a good start.

I had to fix a bug in Pop3Client, which would call listeners multiple times in case of an error.

Depends on D198925

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/623552bb313d
Unit test GuessConfig with startTLS servers. r=john.bieling
https://hg.mozilla.org/comm-central/rev/c4b183a3d04b
Improve unit testing of FetchConfig. r=mkmelin
https://hg.mozilla.org/comm-central/rev/59c30577c904
Refactor test server and certificates handling. r=john.bieling
https://hg.mozilla.org/comm-central/rev/cb174726c8ea
Add tests for verifyConfig. r=john.bieling

Comment 43

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Move tests of widgets into their own directory. r=#thunderbird-reviewers

This patch moves tests that are generally independent of the primary UI into their own directory,
which should help with reliability and efficiency of test development.

Comment 44

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test the many ways the UI triggers fetching new messages. r=#thunderbird-reviewers

… and some ways in which they could go wrong.

Depends on D199317

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/18db60a31689
Move tests of widgets into their own directory. r=mkmelin

Comment 46

[Phabricator Automation]

Comment on attachment 9375936 [details]
Bug 1851536 - Test the many ways the UI triggers fetching new messages. r=#thunderbird-reviewers

Revision D199318 was moved to bug 1878172. Setting attachment 9375936 [details] to obsolete.

Comment 47

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Implement a proxy to convert HTTP requests to HTTPS for tests. r=#thunderbird-reviewers

Comment 48

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Move test certificate files into their own directory. r=#thunderbird-reviewers

Comment 49

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Await `TestUtils.promiseTestFinished` instead of passing test scope around. r=#thunderbird-reviewers

This is much cleaner than passing the test scope to each module and calling registerCleanupFunction
to shut down servers etc..

TestUtils.promiseTestFinished isn't called in XPCShell tests but because they run separately and
everything is cleaned up when the process ends, that doesn't matter.

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2fad2e13c259
Implement a proxy to convert HTTP requests to HTTPS for tests. r=john.bieling
https://hg.mozilla.org/comm-central/rev/a1587a7ec9ca
Move test certificate files into their own directory. r=john.bieling
https://hg.mozilla.org/comm-central/rev/aff3695dce6f
Await `TestUtils.promiseTestFinished` instead of passing test scope around. r=mkmelin

Comment 51

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Add tests for CardDAV address books with DNS discovery and OAuth2 authentication. r=#thunderbird-reviewers

Comment 52

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e7b138a0899
Add tests for CardDAV address books with DNS discovery and OAuth2 authentication. r=mkmelin

Comment 53

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test the Address Book search window. r=#thunderbird-reviewers

Comment 54

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/38d88d580d82
Test the Address Book search window. r=mkmelin

Comment 55

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test importing address book files. r=#thunderbird-reviewers

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5443315df043
Test importing address book files. r=mkmelin

Comment 57

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test that Thunderbird responds to command-line flags correctly. r=#thunderbird-reviewers

This is a basic test of only some of the command-line flags. It's more of an exploration of what I
can and can't do in a Marionette test.

Comment 58

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b5831588f793
Test that Thunderbird responds to command-line flags correctly. r=aleca

Comment 59

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1851536 - Test that Thunderbird saves and restores session.json correctly. r=#thunderbird-reviewers

Comment 60

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97c1307822ee
Test that Thunderbird saves and restores session.json correctly. r=mkmelin

Comment 61

[Geoff Lankow (:darktrojan)]

Calling this done. I'll start a new bug for post-128 work (which should include the patch I just landed, but oh well).