1851667 - [foxfooding] Most links from our Review Quality Check UI end up hitting a fakespot "allow cookies" popup

Status: RESOLVED DUPLICATE of bug 1851612

(Firefox :: Shopping, defect)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Enable the Review Quality Checker.
2. Visit some product page that triggers the sidebar.
   3a. Click the link to the privacy policy or terms of use.
   OR:
   3b. Click the link to try the feature, and click "Re-analyze reviews" if that link is available (in the UI shown in bug 1849697).

ACTUAL RESULTS:
A new tab opens, which gets a prominent popup in the middle with a GDPR allow-or-block-cookies popup.

EXPECTED RESULTS:
No such cookie popups as part of a core "built-in-feeling" Firefox feature.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of cookie-prompt when I click over to re-analyze reviews from the sidebar

(In reply to Daniel Holbert [:dholbert] from comment #0)

3b. Click the link to try the feature, and click "Re-analyze reviews" if that link is available (in the UI shown in bug 1849697).

Here's a screenshot of how this issue looks from this^ "re-analyze reviews" flow. (As noted in the red text that I drew on top [which my screenshotting tool partly clipped, whoops]: the UI to actually do the re-analyzing is covered up by the cookie popup.)

Comment 2

[Daniel Holbert [:dholbert]]

EXPECTED RESULTS:
No such cookie popups as part of a core "built-in feeling" Firefox feature.

Clarifying myself somewhat: of course, if we're actually using cookies and we're legally required to show this prompt, then of course we should show it.

The premise her is more: do we actually use (or need to use) cookies here. At least for the the privacy policy and terms-of-use pages, those seem like things we could serve without setting any particular cookies and without needing a prompt to get in the user's way. I'm less sure about the "re-analyze" flow, but it seems like that doesn't necessarily need cookies either, at least no more than other core browser features that have some sort of web-hosted portion.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of cookie prompt when I click through to privacy policy

Here's a screenshot of what the privacy policy looks like when I click through to it from the welcome content in the sidebar, the first time you view a product page that triggers the feature.

Comment 4

[Daniel Holbert [:dholbert]]

note: if your window is a bit wider than the windows I've screenshotted here, then the cookie prompt instead ends up being a "fixed footer" instead of a "floating-in-the-middle dialog". The fixed-footer UI looks a bit less intrusive and it's easier to ignore. The centered layout (shown in the screenshots here) essentially forces the user to stop what they're doing and make a cookie choice before they can proceed, which is a bit unfortunate, and that's what prompted me to file this.

Comment 5

[Daniel Holbert [:dholbert]]

I should also note, I'm in the US, so these cookie prompts are a bit less of an everyday experience for me than they might be for folks in the EU. :)

Comment 6

[Daniel Holbert [:dholbert]]

Update: I mentioned this in our fakespot slack channel as well, and I heard back that we removed the cookies popup on the privacy policy and terms-of-service pages. So those are no longer an issue.

Also, for "re-analyze reviews", bug 1851612 will make that no longer open an external website.

So: the remaining trouble here is essentially a dupe of bug 1851612. Resolving as-such.