Closed Bug 185167 Opened 19 years ago Closed 18 years ago

Display of BMPString (UTF-8) encoded fields of certificate is bad

Categories

(Core Graveyard :: Security: UI, defect)

1.0 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: t8m, Assigned: jgmyers)

Details

Attachments

(3 files)

When you try to display Details of certificate which has some fields with
non-ascii characters (encoded as BMPString). The display is wrong as it was
encoded with iso8859-1 encoding.

See attached screenshot.
Version: unspecified → 2.4
Attached patch Proposed fixSplinter Review
Taking.
Assignee: ssaux → jgmyers
Attachment #138792 - Attachment description: P → Proposed fix
Attachment #138792 - Flags: review?(ssaux)
Comment on attachment 138792 [details] [diff] [review]
Proposed fix

I'm probably not the best person to give reviews on PSM. Kai Engert would be
the best person.
Attachment #138792 - Flags: review?(ssaux) → review+
Attachment #138792 - Flags: superreview?(scc)
Attachment #138792 - Flags: superreview?(scc) → superreview?(sspitzer)
Comment on attachment 138792 [details] [diff] [review]
Proposed fix

sr=sspitzer, but can we also get kai to review?
Attachment #138792 - Flags: superreview?(sspitzer)
Attachment #138792 - Flags: superreview+
Attachment #138792 - Flags: review?(kaie)
Attachment #138792 - Flags: review+
Comment on attachment 138792 [details] [diff] [review]
Proposed fix

r=kaie
Attachment #138792 - Flags: review?(kaie) → review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
When I try to verify this bug, I still find one problem left, John.

After import of the certificate, everything's correct except for the copy of the
name of the certificate inside the title bar of the "Certificate Viewer"
windows, which incorrectly reads "Certificate Viewer:LudÄ_k RaÄiek" instead of
the proper czech characters.

As the original content of the cert CN is BMP, it has somewhere been correctly
converted to utf-8, but that string is later somewhere wrongly interpreted as
ISO-8859-1 before display.

Shall we reopen, or treat this in a separate bug ?

Just like bug 197009, it would be good to get this inside NSS 3.9.1, and then in
1.7.b.

I think this is even more important than bug 197009, because it seems to concern
all certs that have utf-8/BMP content, and by application of RFC3280, CA are
required to switch to the use of UTF-8 for certificates issued after 31/12/2003,
 and this is respected by some people.
I would treat as a separate bug.
I tried to import the bug into FireFox 0.8 and the problem is still present.
the certificate titlebar viewing issue is bug 234856
Product: PSM → Core
Version: psm2.4 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.