1851671 - [foxfooding] Firefox Nightly icon gets clipped if you zoom the sidebar

Status: RESOLVED FIXED

(Firefox Graveyard :: Shopping, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing clipped icon

STR:

1. Activate the Review Quality Check shopping experience, and visit some product page and click "Try it" in the sidebar.
2. Hover the sidebar and zoom in (Ctrl + Mousewheel)

ACTUAL RESULTS:
The sidebar's content responds to the zoom in a mostly-elegant way, except that the Firefox Nightly icon gets progressively more clipped. See attached screenshot.

EXPECTED RESULTS:
No such clipping on the icon.

(There are a handful of related issues regarding zooming on this sidebar; I filed bug 1851657 for a different issue that only reproduces on the initial welcome-to-the-feature UI.)

Comment 1

[Daniel Holbert [:dholbert]]

One fix here is to add these properties to our #shopping-icon CSS rule at https://searchfox.org/mozilla-central/rev/b6cd901cf074c5e75e3902d660bafa3cf3967c40/browser/components/shopping/content/shopping-container.css#20 :

background-size: contain;
background-repeat: no-repeat;

That seems to address the issue for me. (With this, the icon remains the same size as you zoom, and doesn't get clipped.)

Comment 2

[:Gijs (he/him)]

The logo in the header is going away (bug 1851835 has a patch which addresses bug 1851853 which explicitly called this out). That should take care of this bug.

Comment 3

[:Gijs (he/him)]

This is fixed/wfm now that the icon is gone (should be in today's nightly in 1-2h from now).