1851816 - FPP + RFP.pbMode apply RFP globally

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Tom Ritter [:tjr]]

If FPP is enabled, and RFP.pbMode is enabled, the RFP behavior is still applied in regular windows, even though it should only be in PBMode.

(We should add a test for this as well, shouldn't be hard with the HWConcurrency setup.)

Comment 1

[Harshit Sohaney [:hsohaney]]

Could you help us assign a priority and severity for this bug?

Comment 2

[Tom Ritter [:tjr]]

Tim, Tom, or I will take this.

Comment 3

[Tim Huang[:timhuang]]

Tom, do you mind taking this bug for now?

Comment 4

[Tom Ritter [:tjr]]

Attachment: Bug 1851816: Add tests for RFP in PBMode and FPP in Regular r?timhuang

It fails without any patch as expected.

Comment 5

[Tom Ritter [:tjr]]

Attachment: Bug 1851816: Pass PBM Status into RFPIsEnabledFor r?timhuang

Depends on D192500

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d0d2fe95e67
Add tests for RFP in PBMode and FPP in Regular r=timhuang
https://hg.mozilla.org/integration/autoland/rev/d2f63b3f6342
Pass PBM Status into RFPIsEnabledFor r=timhuang

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1851816) for causing private browsing related failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=SSXR6YRaRo-jCuRcF4Yv1w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d2f63b3f6342783e5a3e09099f1c88a54cb3f1c2

Log: https://treeherder.mozilla.org/logviewer?job_id=435223015&repo=autoland&lineNumber=19433
https://treeherder.mozilla.org/logviewer?job_id=435222927&repo=autoland&lineNumber=3089
https://treeherder.mozilla.org/logviewer?job_id=435223538&repo=autoland&lineNumber=2712
https://treeherder.mozilla.org/logviewer?job_id=435224205&repo=autoland&lineNumber=7976
https://treeherder.mozilla.org/logviewer?job_id=435224086&repo=autoland&lineNumber=10912

Backout: https://hg.mozilla.org/integration/autoland/rev/f1c638e19c43cdf2a45ca2aaab9b82ee74a35165

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 9

[Tim Huang[:timhuang]]

Tom, any plan to land the patches in the near future?

Comment 10

[Tim Huang[:timhuang]]

Discussed with Tom, we think that we can lower the severity and priority because this issue doesn't affect regular PBM and ETP strict users.

Comment 11

[Tom Ritter [:tjr]]

Okay, I think I figured out the problem with the patch - I actually learned it when reviewing one of your recent patches and then noticed it when looking at this today. DEFAULT_PRIVATE_BROWSING_ID represents when you are NOT in PBM. Not when you are. Unintuitive. I added a comment to the constant in the next patchset I'll put up on phab after try is (hopefully) green...

https://treeherder.mozilla.org/jobs?repo=try&revision=7ef0fd71f01917dcc7f47b508e2eb5f6534bf0ac

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39c0e60315fc
Add tests for RFP in PBMode and FPP in Regular r=timhuang
https://hg.mozilla.org/integration/autoland/rev/b2b860053286
Pass PBM Status into RFPIsEnabledFor r=timhuang

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/39c0e60315fc
https://hg.mozilla.org/mozilla-central/rev/b2b860053286