1851868 - Refactor nsIFrame::Destroy to pass a single DestroyContext parameter.

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1851868 - Refactor nsIFrame::Destroy to pass a single DestroyContext parameter. r=dholbert

This shouldn't change behavior, but it packs the two arguments to
DestroyFrom into a single thing, and makes nsIFrame::Destroy not so easy
to call without a previous context.

This is a prerequisite to pass aDestroyContext to various things that
right now just mint one, which can cause badness, see bug 1851787 and
related bugs.

It's also a bit nicer to add things there if we need to in the future.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55052ae7d067
Refactor nsIFrame::Destroy to pass a single DestroyContext parameter. r=dholbert

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for reftest failure on 1153695.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/8987306509494248ca5c40165f6330d31bf74d8e
Log link: https://treeherder.mozilla.org/logviewer?job_id=428199433&repo=autoland&lineNumber=332755

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0acb0f0a8cdc
Refactor nsIFrame::Destroy to pass a single DestroyContext parameter. r=dholbert

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/0acb0f0a8cdc

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/006f3d725ce0