Closed
Bug 1851900
Opened 2 years ago
Closed 2 years ago
[wpt-sync] Sync PR 41852 - Apply changes from code review comments.
Categories
(Testing :: web-platform-tests, task, P4)
Testing
web-platform-tests
Tracking
(firefox120 fixed)
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 41852 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/41852
Details from upstream follow.
mark a. foltz <mfoltz@chromium.org> wrote:
Apply changes from code review comments.
This PR updates the previous PR #35827 with edits suggested in code review.
- Updated README.md
- Removed extra parens around arrow functions
- Updated test descriptions and titles
|
Assignee | |
Comment 1•2 years ago
|
||
PR 41852 applied with additional changes from upstream: fcda0e0b577857435be8a429471e5da0cdb571f3
|
|
Assignee | |
Updated•2 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
|
|
Assignee | |
Updated•2 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5916b697c03c796813da5182d3f4680472739029
|
|
Assignee | |
Comment 3•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 7 tests and 1 subtests
Status Summary
Firefox
OK : 7
FAIL: 8
Chrome
OK : 7
PASS: 7
FAIL: 1
Safari
OK : 7
PASS: 7
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
- /remote-playback/cancel-watch-availability.html [wpt.fyi]
- Test that calling cancelWatchAvailability() with an id does remove the callback, and calling cancelWatchAvailability with a removed id throws NotFoundError.:
FAIL - Test that calling cancelWatchAvailability() without an id removes all the callbacks, and calling cancelWatchAvailability() with a removed id throws NotFoundError.:
FAIL
- Test that calling cancelWatchAvailability() with an id does remove the callback, and calling cancelWatchAvailability with a removed id throws NotFoundError.:
- /remote-playback/disable-remote-playback-cancel-watch-availability-throws.html [wpt.fyi]
- Test that calling cancelWatchAvailability() when disableRemotePlayback attribute is set throws InvalidStateError.:
FAIL
- Test that calling cancelWatchAvailability() when disableRemotePlayback attribute is set throws InvalidStateError.:
- /remote-playback/disable-remote-playback-prompt-throws.html [wpt.fyi]
- Test that calling prompt() when disableRemotePlayback attribute is set throws an exception.:
FAIL
- Test that calling prompt() when disableRemotePlayback attribute is set throws an exception.:
- /remote-playback/disable-remote-playback-watch-availability-throws.html [wpt.fyi]
- Test that calling watchAvailability() when disableRemotePlayback attribute is set throws an exception.:
FAIL
- Test that calling watchAvailability() when disableRemotePlayback attribute is set throws an exception.:
- /remote-playback/watch-availability-initial-callback.html [wpt.fyi]
- Test that the callback is called after the Promise returned by watchAvailability() resolves.:
FAIL
- Test that the callback is called after the Promise returned by watchAvailability() resolves.:
- /remote-playback/watch-availability-promise-return-callback-id.html [wpt.fyi]
- Test that the Promise returned by watchAvailability() resolves with a numeric callback id.:
FAIL
- Test that the Promise returned by watchAvailability() resolves with a numeric callback id.:
New Tests That Don't Pass
- /remote-playback/cancel-watch-availability.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)- Test that calling cancelWatchAvailability() with an id does remove the callback, and calling cancelWatchAvailability with a removed id throws NotFoundError.:
FAIL(Chrome:PASS, Safari:PASS) - Test that calling cancelWatchAvailability() without an id removes all the callbacks, and calling cancelWatchAvailability() with a removed id throws NotFoundError.:
FAIL(Chrome:PASS, Safari:PASS)
- Test that calling cancelWatchAvailability() with an id does remove the callback, and calling cancelWatchAvailability with a removed id throws NotFoundError.:
- /remote-playback/disable-remote-playback-cancel-watch-availability-throws.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)- Test that calling cancelWatchAvailability() when disableRemotePlayback attribute is set throws InvalidStateError.:
FAIL(Chrome:PASS, Safari:PASS)
- Test that calling cancelWatchAvailability() when disableRemotePlayback attribute is set throws InvalidStateError.:
- /remote-playback/disable-remote-playback-prompt-throws.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)- Test that calling prompt() when disableRemotePlayback attribute is set throws an exception.:
FAIL(Chrome:PASS, Safari:PASS)
- Test that calling prompt() when disableRemotePlayback attribute is set throws an exception.:
- /remote-playback/disable-remote-playback-watch-availability-throws.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)- Test that calling watchAvailability() when disableRemotePlayback attribute is set throws an exception.:
FAIL(Chrome:PASS, Safari:PASS)
- Test that calling watchAvailability() when disableRemotePlayback attribute is set throws an exception.:
- /remote-playback/watch-availability-callback-parameter.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)- Test that the callback is called with boolean parameter when calling watchAvailability().:
FAIL(Chrome:FAIL, Safari:FAIL)
- Test that the callback is called with boolean parameter when calling watchAvailability().:
- /remote-playback/watch-availability-initial-callback.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)- Test that the callback is called after the Promise returned by watchAvailability() resolves.:
FAIL(Chrome:PASS, Safari:PASS)
- Test that the callback is called after the Promise returned by watchAvailability() resolves.:
- /remote-playback/watch-availability-promise-return-callback-id.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)- Test that the Promise returned by watchAvailability() resolves with a numeric callback id.:
FAIL(Chrome:PASS, Safari:PASS)
- Test that the Promise returned by watchAvailability() resolves with a numeric callback id.:
Tests Disabled in Gecko Infrastructure
- /remote-playback/cancel-watch-availability.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK) - /remote-playback/disable-remote-playback-cancel-watch-availability-throws.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK) - /remote-playback/disable-remote-playback-prompt-throws.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK) - /remote-playback/disable-remote-playback-watch-availability-throws.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK) - /remote-playback/watch-availability-callback-parameter.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK) - /remote-playback/watch-availability-initial-callback.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK) - /remote-playback/watch-availability-promise-return-callback-id.html [wpt.fyi]:
OK[GitHub],SKIP[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:OK, Safari:OK)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/a336bd7a02c6
[wpt PR 41852] - Apply changes from code review comments., a=testonly
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•