1852083 - Crash in [@ java.lang.NullPointerException: at java.util.HashMap.hash(HashMap.java)]

Status: RESOLVED FIXED

(Firefox for Android :: Crash Reporting, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This signature started to get reported for Fenix 116.3.0 but not for 116.0 or 116.2.0 (116.1.0 did not get released). There are ~1000 crash reports for it.

Could this be a consequence of the change in bug 1838389?

Crash report: https://crash-stats.mozilla.org/report/index/f8832e87-6e66-437b-9449-aa49c0230907

Frame	Module	Function	Source	In app?
0	java.util.HashMap	hash	HashMap.java:338	True
1	java.util.HashMap	put	HashMap.java:611	True
2	java.util.HashSet	add	HashSet.java:219	True
3	mozilla.components.lib.crash.service.MozillaSocorroService	sendCrashData	MozillaSocorroService.kt:648	True
4	mozilla.components.lib.crash.service.MozillaSocorroService	sendReport$lib_crash_release	MozillaSocorroService.kt:285	True
5	mozilla.components.lib.crash.service.MozillaSocorroService	report	MozillaSocorroService.kt:5	True
6	mozilla.components.lib.crash.CrashReporter$submitReport$2	invokeSuspend	CrashReporter.kt:70	True
7	kotlin.coroutines.jvm.internal.BaseContinuationImpl	resumeWith	ContinuationImpl.kt:9	True
8	kotlinx.coroutines.DispatchedTask	run	DispatchedTask.kt:112	True
9	kotlinx.coroutines.internal.LimitedDispatcher$Worker	run	LimitedDispatcher.kt:4	True
10	kotlinx.coroutines.scheduling.TaskImpl	run	Tasks.kt:3	True
11	kotlinx.coroutines.scheduling.CoroutineScheduler$Worker	run	CoroutineScheduler.kt:96	True

Comment 1

[Roger Yang [:royang]]

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #0)

This signature started to get reported for Fenix 116.3.0 but not for 116.0 or 116.2.0 (116.1.0 did not get released). There are ~1000 crash reports for it.

Could this be a consequence of the change in bug 1838389?

Possible, I'll take a look.

Comment 2

[Chris Peterson [:cpeterson]]

Here's a related crash signature from the Google Play console, though I don't see this signature in Socorro:

[@ java.lang.NullPointerException: at at java.util.HashMap.hash(HashMap.java:338)]

https://play.google.com/console/u/0/developers/7083182635971239206/app/4972519468758466290/vitals/crashes/51a3e29d62a914d51048c1c30750c51c/details?days=28

Exception java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Object.hashCode()' on a null object reference
  at java.util.HashMap.hash (HashMap.java:338)
  at java.util.HashMap.put (HashMap.java:611)
  at java.util.HashSet.add (HashSet.java:219)
  at mozilla.components.lib.crash.service.MozillaSocorroService.sendCrashData (MozillaSocorroService.kt:648)
  at mozilla.components.lib.crash.service.MozillaSocorroService.sendReport$lib_crash_release (MozillaSocorroService.kt:285)
  at mozilla.components.lib.crash.service.MozillaSocorroService.report (MozillaSocorroService.kt:5)
  at mozilla.components.lib.crash.CrashReporter$submitReport$2.invokeSuspend (CrashReporter.kt:70)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:9)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:112)
  at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run (LimitedDispatcher.kt:4)
  at kotlinx.coroutines.scheduling.TaskImpl.run (Tasks.kt:3)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:96)

Comment 3

[Roger Yang [:royang]]

This is definitely not caused by the change in bug 1838389, but it could be that this is now another crash that the fix uncovers.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on beta

:royang, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1852083 - Do not insert extra with null or empty key (#3846)

Comment 6

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/3759fab8ba34b1b967c10c8d6ebb790b2cb9ea2d
[main] Bug 1852083 - Do not insert extra with null or empty key

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1852083 - Do not insert extra with null or empty key (backport #3846) (#3895)

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1852083 - Do not insert extra with null or empty key (backport #3846) (#3896)

Comment 9

[Roger Yang [:royang]]

Don't know any way to reproduce this issue. We'll have to uplift this fix to release to see if this is fixing the issue causing the crash.

Comment 10

[Roger Yang [:royang]]

Comment on attachment 9355605 [details] [review]
[mozilla-mobile/firefox-android] Bug 1852083 - Do not insert extra with null or empty key (#3846)

Beta/Release Uplift Approval Request

• User impact if declined: Crash when key is null or empty
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is to fix one of the possible path for this crash. Even if it's not the fix, it's a good and safe patch to be in release.
• String changes made/needed: N/A
• Is Android affected?: Yes

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9356201 [details] [review]
[mozilla-mobile/firefox-android] Bug 1852083 - Do not insert extra with null or empty key (backport #3846) (#3896)

changing flags to match its corresponding branch

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9356200 [details] [review]
[mozilla-mobile/firefox-android] Bug 1852083 - Do not insert extra with null or empty key (backport #3846) (#3895)

Approved for Mobile 119.0b5

Comment 13

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/2b4aa8d16a5146a3791d122587031bf74f14f698
[releases_v119] Bug 1852083 - Do not insert extra with null or empty key

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9356201 [details] [review]
[mozilla-mobile/firefox-android] Bug 1852083 - Do not insert extra with null or empty key (backport #3846) (#3896)

Approved for our next 118 dot release, thanks.

Comment 15

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/b956bf9808314e490b7ced269e8542bff86a8df2
[releases_v118] Bug 1852083 - Do not insert extra with null or empty key