1852092 - Exceptions list in dialog has no minimum height and can appear empty in small windows

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Kestrel]

Attachment: Exceptions list not visibile in small window

STR:

1. Open about:preferences#privacy.
2. Reduce the height of the window to less than 450px.
3. Click any of the Exceptions buttons.

Expected:
Exceptions list has enough height to be visible and scrollable.

Actual:
Exceptions list has no height and appears empty.

#permissionsBox richlistbox has 0px height.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c3037ba20d8b6200b240e4025a86855b74741a52&tochange=b68ba468c8215e516b1a0f00509bd70c857fd518

Regressed by Bug 1822453.

Comment 1

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1822453, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

This looks fairly obscure. Maybe a minimum 1em height would work?

Comment 3

[Kestrel]

A user encountered this issue with a small laptop screen which caused them a lot of confusion:
https://support.mozilla.org/en-US/questions/1422944

I think at least two rows should be visible (5em) so it looks like a list and the scrollbar is not too cramped and awkward.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1852092 - Add some min height to permission lists. r=mconley,dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd21084d88f5
Add some min height to permission lists. r=mconley,dao,settings-reviewers,desktop-theme-reviewers

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cd21084d88f5

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-09-07 Nightly build on Windows 10.
Verified as fixed on Firefox 119.0b4(build ID: 20231002091755) and Nightly 120.0a1(build ID: 20231002221644) on Windows 10, macOS 12, Ubuntu 22.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR115 approval when you get a chance.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9353355 [details]
Bug 1852092 - Add some min height to permission lists. r=mconley,dao

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: comment 0
• User impact if declined: UI less polished
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS tweak.

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9353355 [details]
Bug 1852092 - Add some min height to permission lists. r=mconley,dao

Approved for 115.4esr.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/122fd292adeb

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox ESR 115.4.0(build ID: 20231016232700) on Windows 10, macOS 12, Ubuntu 22.