1852144 - Make remote canvas a gfx feature

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

This will make it easier to understand if a user is using remote canvas or not when reporting issues. It also changes how we disable remote canvas in the case of errors, so that it affects all processes instead of just one content process. Disabling should be rare in general.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1852144 - Disable remote canvas globally in case of unrecoverable error.

This patch makes the remote canvas enabled state global. If we failed to
create a context, then it cannot recover, so we should never try again.
In the event of stream errors, it is likely due to virtual memory
shortages.

Depends on D187717

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Data review, v1

Comment 3

[Chris H-C :chutten]

Comment on attachment 9353974 [details]
Data review, v1

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 130.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4f5b9d5cd38
Disable remote canvas globally in case of unrecoverable error. r=gfx-reviewers,lsalzman

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b4f5b9d5cd38