Closed
Bug 1852148
Opened 1 years ago
Closed 1 year ago
Switch Open Tabs card layout to 2 columns on narrow viewports
Categories
(Firefox :: Firefox View, defect, P2)
Firefox
Firefox View
Tracking
()
RESOLVED
FIXED
119 Branch
Tracking | Status | |
---|---|---|
firefox119 | --- | fixed |
People
(Reporter: kcochrane, Assigned: kcochrane)
References
Details
(Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
On the Open Tabs page of Firefox View, we need to switch to a 2-column layout for the cards when the viewport width is below 1366px. When the viewport is too narrow, and we're still applying a 3-column layout, the tab titles are truncated beyond being of much use to the user.
We can resolve this by adding a media query in view-opentabs.css
for when the window width is a max of 1365px (we may want to convert this to rem actually), then redefine the .three-column
styles to match the .two-column
styles.
Updated•1 years ago
|
Comment 1•1 year ago
|
||
I'm calling this a bug. The information this view presents isn't really legible in circumstances that are normal and expected.
Severity: -- → S3
Type: task → defect
Priority: -- → P2
Assignee | ||
Updated•1 year ago
|
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•1 year ago
|
||
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6ecdc6c2215
Switch Open Tabs card layout to 2 columns on narrow viewports in Firefox View r=jsudiaman,desktop-theme-reviewers,fxview-reviewers,sfoster
Comment 4•1 year ago
|
||
Backed out for causing mochitest failures in test_opentabs.html
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/chrome/test_opentabs.html | The container shows one column when one window is open.
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e85748b0b988
Switch Open Tabs card layout to 2 columns on narrow viewports in Firefox View r=jsudiaman,desktop-theme-reviewers,fxview-reviewers,sfoster
Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(kcochrane)
Comment 6•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•