Closed Bug 1852152 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 41869 - [GridNG] Update test expectation for grid-template-shorthand-valid.html

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41869 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41869
Details from upstream follow.

Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com> wrote:

[GridNG] Update test expectation for grid-template-shorthand-valid.html

Per https://drafts.csswg.org/cssom/#serializing-css-values "If component
values can be omitted or replaced with a shorter representation without
changing the meaning of the value, omit/replace them."

This means that when serializing grid-template-*, we should always
omit auto sizes in grid-template-* serialization as it is the
default value, so it will always be a shorter representation
without changing the value. This should happen regardless of whether
it was specified by the author.

This means that the final test case expectation in
grid-template-shorthand-valid.html is incorrect. It is also failing in
Blink/Gecko/WebKit for this exact reason, so this CL updates the test's
expected behavior to omit auto. After this change, it passes
everywhere.

Bug: 1028283
Change-Id: I640f450e50df45c404b46c17c2d9cdce49313c60
Reviewed-on: https://chromium-review.googlesource.com/4851233
WPT-Export-Revision: c7c294151e4f07650ff2ae944e8a9749eb9793db

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a41a4b2a72bc [wpt PR 41869] - [GridNG] Update test expectation for grid-template-shorthand-valid.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/ac362f8f5092 [wpt PR 41869] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a41a4b2a72bc
https://hg.mozilla.org/mozilla-central/rev/ac362f8f5092

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.