1852191 - popup tooltip of html element appear even when window is out of focus

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[fanzhuyifan+github]

Attachment: test.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

Environment: firefox nightly on linux with X11, on xfce with xfwm

1. hover the mouse on top of a html element that will show a tooltip (e.g., see attached html)
2. before the tooltip appears, alt-tab to switch window, or use hot key to change to another workspace

Actual results:

The tooltip appears (possibly above other windows or in another workspace), even though firefox is not in focus.

Expected results:

The tooltip shouldn't have appeared, or should have stayed with the corresponding firefox window.

Comment 1

[fanzhuyifan+github]

This is different from 148624 in that 148624 was related to XUL components, while this is related to HTML elements on web pages displaying in firefox.

Comment 2

[fanzhuyifan+github]

(In reply to fanzhuyifan+github from comment #1)

This is different from 148624 in that 148624 was related to XUL components, while this is related to HTML elements on web pages displaying in firefox.

What I previously said is incorrect. By adding print statements, I can confirm that the relevant code is also the ShowTooltip() function from layout/xul/nsXULTooltipListener.cpp. So this is related to 148624.
In addition, I confirmed on my computer that this is not a regression caused by https://phabricator.services.mozilla.com/D187418

Comment 3

[fanzhuyifan+github]

Further debugging shows that ShowTooltip() is called and correctly exists from the fix https://phabricator.services.mozilla.com/D187418
However, for some reason the tooltip still shows up.

Comment 4

[fanzhuyifan+github]

I added more print statements and here is the call graph I think is causing the graph:

1. In docshell/base/nsDocShellTreeOwner.cpp, sTooltipCallback is fired
2. This calls ShowTooltip in the same file
3. This calls OnShowTooltip from dom/ipc/BrowserChild.cpp
4. This calls SendShowTooltip
5. So RecvShowTooltip from dom/ipc/BrowserParent.cpp is called
6. This calls XULBrowserWindow.showTooltip from browser/base/content/browser.js

None of these steps checks if the relevant firefox window has lost focus. Hence, the tooltip is erroneously displayed.
To fix the issue, where do you think we should insert code to check if the current window is active?

Comment 5

[fanzhuyifan+github]

Attachment: Bug 1852191 - Only show tooltip when document has focus. r=emilio,stransky,masayuki

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/640ad6a53cf8
Only show tooltip when document has focus. r=emilio

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/640ad6a53cf8