1852236 - New logins added manually from about:logins page are not synced

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: error-sync-1694166962384.txt

Notes

• about:sync log file attached.
• Screen recording.

Found in

• Firefox 118.0b6;

Affected versions

• Firefox 118.0b6;
• Nightly 119.0a1;

Tested platforms

• macOS 12;
• Windows 10;
• Ubuntu 22;

Affected platforms

• macOS 12;
• Windows 10;
• Ubuntu 22;

Unaffected platforms

• N/A;

Preconditions

• Valid credentials for an Fx Account.

Steps to reproduce

1. Create a new profile, for example profile A.
2. Navigate to about:logins.
3. Log into the Fx account. ( It’s easier to test if the login page is empty, or has fewer logins)
4. Manually add one or two new logins from the about:logins page.
5. Sync Now on profile A.
6. Create a new profile, for example profile B.
7. Navigate to about:logins on profile B.
8. Login with the same account from step 3 on profile B.
9. Sync Now on profile B.

Expected result

• The newly added logins in Step 4 from profile A should be synced onto profile B.

Actual result

• Logins do not sync.

Regression range

• Mozregression points to:
• last good: 2023-08-14
• first bad: 2023-08-15
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=88ec6682eab1c5c36cb839c8db0156446559a1cb&tochange=2125dc1611bef4236c0d3c89e79040a8ece7b8e1
• Potentially regressed by: bug 1846036

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1846036

:enndeakin, since you are the author of the regressor, bug 1846036, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Neil Deakin]

Attachment: Bug 1852236, treat null string formActionOrigin values as not present in certain cases, also restores some checks of formActionOrigin that got lost, r?#credential-management-reviewers

Comment 3

[Donal Meehan [:dmeehan]]

:neil deakin can we consider backing this regressor out from beta for Fx118?
We are in the final week of beta, or will this land soon and request uplift?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c77f534dc9b9
treat null string formActionOrigin values as not present in certain cases, also restores some checks of formActionOrigin that got lost, r=credential-management-reviewers,sgalich

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c77f534dc9b9

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

(In reply to Donal Meehan [:dmeehan] from comment #3)

:neil deakin can we consider backing this regressor out from beta for Fx118?
We are in the final week of beta, or will this land soon and request uplift?

Our last beta is tomorrow, are we OK to ship 118 with this regression or should we uplift the fix that landed yesterday?

Comment 7

[Neil Deakin]

If the beta is that soon, would it be easier/safer to back out 1846036? That bug is just a cleanup patch and isn't an important change.

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

let's backout bug 1846036 then

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

Backed out changeset 2125dc1611be (bug 1846036) for causing bug 1852236
https://hg.mozilla.org/releases/mozilla-beta/rev/24d2ddc46990

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is verified as fixed on Firefox 119.0b2(build ID: 20230927091517) and Nightly 120.0a1(build ID: 20230928215127) on Windows 10, macOS 12, Ubuntu 22.