1852253 - ‘Password saved!’ string missing when saving a securely generated password

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P2)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: Screenshot 2023-09-08 at 15.01.37.png

Notes

• Screenshot of the issue attached;

Found in

• Firefox 118.0b6;

Affected versions

• Firefox 118.0b6;
• Nightly 119.0a1;

Tested platforms

• macOS 13;
• Windows 10;
• Ubuntu 22;

Affected platforms

• macOS 13;
• Windows 10;
• Ubuntu 22;

Unaffected platforms

• N/A;

Preconditions

• New profile(default settings);

Steps to reproduce

1. Launch Firefox.
2. Navigate to https://www.facebook.com
3. Click the ‘Create new account’ button.
4. Right click on the New Password field.
5. Click the ‘Suggest Strong Password…’ option from the dropdown.
6. Click the ‘ Use a securely generated password’ option from the dropdown.

Expected result

• "Password saved!" toast is displayed.

Actual result

• "Password saved!" toast is NOT displayed, only the ‘check’ animation is displayed.

Regression range

• Mozregression points to:
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=42a4b2af29229dbfd0675767afaf6965d292e4a7&tochange=bd605fc6cb3ea7ad58f7d8ec43da4920ad48a9fa
• Potentially regressed by: bug 1398681

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1398681

:issammani, since you are the author of the regressor, bug 1398681, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Can we triage this? How urgent is it to get this fixed in 118?

Comment 3

[Issam Mani [:issammani]]

Attachment: Bug 1852253 - Use identity anchor by default for confirmation hints. r=#credential-management-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59d0c1ce544d
Use identity anchor by default for confirmation hints. r=credential-management-reviewers,sgalich

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/59d0c1ce544d

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:issammani, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Sergey Galich [:serg]]

Attachment: image.png

I can still see the problem in Fx120

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Removing the qa-verify flag since this issue was further addressed in bug 1856709 .