1852326 - [wpt-sync] Sync PR 41835 - Renderer Process Crashes in Print Preview Popup Due to Null Return in GetFrame() During Execution.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41835 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41835
Details from upstream follow.

shaochenguang <[e-mail]> wrote:

Renderer Process Crashes in Print Preview Popup Due to Null Return in GetFrame() During Execution.

If a web page has a button that triggers a print preview popup, and when the popup appears,
clicking the refresh button causes the Renderer process to crash.
If loading_for_print_ is true, GetFrame()->Client()->DispatchDidFinishLoadForPrinting() that after the execution is completed, there is a possibility of GetFrame() returning null.
So after this, it is necessary to determine whether it is empty.
If it is empty, false should be returned.

Bug: 1478487
Change-Id: Ieac77cba80f7c0115dfaea1c0dc3731a5b30dd2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835376
Reviewed-by: Daniel Cheng \<[e-mail]>
Reviewed-by: Nate Chapin \<[e-mail]>
Reviewed-by: Chris Harrelson \<[e-mail]>
Commit-Queue: Nate Chapin \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1194228}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd4d04e3c7da5afed15f31cfa324231629083cc3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1
TIMEOUT: 1

Chrome

CRASH : 1

Safari

ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /print/crashtests/reload-crash.html [wpt.fyi]: PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], TIMEOUT [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: CRASH, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f2487421a6c
[wpt PR 41835] - Renderer Process Crashes in Print Preview Popup Due to Null Return in GetFrame() During Execution., a=testonly
https://hg.mozilla.org/integration/autoland/rev/23e8e05e56fa
[wpt PR 41835] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0f2487421a6c
https://hg.mozilla.org/mozilla-central/rev/23e8e05e56fa