185239 - "print frame" in context menu (under "this frame")

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement, P2)

Description

[Xeno Genic]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5

Plz add a "print frame /iframe" option to the rightclick context menu under This
Frame. Also needed: a way to select the frame iframe for printing. IE does this
by cursor location, or location of javasript code execution (ie: from a link on
the iframe page).

Reproducible: Always

Steps to Reproduce:
1. visit url 
2. select text in frame of iframe
3. print
Actual Results:  
Print doesnt print whole frame/frame
Print doesnt exclusively print frame/iframe

Expected Results:  
Print whole frame/frame
Print exclusively frame/iframe

Comment 1

[Sébastien Delahaye]

Confirming for developer review, and setting OS to all.

Comment 2

[Ed Hume]

I'd like to vote for this one, along with a related request (tell me if you want
a separate request): With graphics, I would like to see a Print Graphic item on
the right-click context menu. I use this a lot when preparing for a trip. I go
to Mapquest using IE, and directly print the maps I need. With Px, one must save
the map to disk, then leave the browser and print the map. Having Print Graphic
(like IE's Print Picture) in the right-click menu would make life so much easier.

Comment 3

[Jesse Ruderman]

This is a dup of bug 137014, except that this bug is for Phoenix and 137014 is
for Mozilla.

Comment 4

[Simon Paquet [:sipaq]]

Taking QA Contact as designated owner of Firebird-Menus. Sorry for bugspam.

Comment 5

[Kevin Ar18]

Bug 204519 proposes the same thing as this bug, with the following exceptions:

Differences
1. The context menu option would be simply "Print"

Similarities
1. The context menu option would be frame sensitive like in IE.

Comment 6

[Nickolay_Ponomarev]

*** Bug 285501 has been marked as a duplicate of this bug. ***

Comment 7

[Worcester12345]

I forgot all about this one. Is there another, easier way of printing a specific
frame?

Comment 8

[Worcester12345]

(In reply to comment #7)
> I forgot all about this one. Is there another, easier way of printing a
> specific
> frame?
> 

Anyone?

Comment 9

[Worcester12345]

" You tried to request blocking-firefox3. Only a sufficiently empowered user can make this change."

Could someone please mark this one? Thank you.

Comment 10

[Asaf Romano (gone)]

Attachment: patch

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 245722 [details] [diff] [review]
patch

>Index: toolkit/components/printing/content/printUtils.js

>+    var contentWindow = aWindow ? aWindow : window.content;

nit: I kinda prefer |var contentWindow = aWindow || window.content;|, but I don't care that much so up to you (same comment applies elsewhere in the file).

Comment 12

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-context.inc 1.29
mozilla/browser/base/content/nsContextMenu.js,1.5
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 1.57
mozilla/toolkit/components/printing/content/printUtils.js 1.26 (and 1.27)