185247 - HavePrivateHTMLFlavor should not return PRBool

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[harishd]

IMO, nsHTMLEditor::HavePrivateHTMLFlavor should return nsresult instead of PRBool.
That is, the function should looks something like this:

nsresult 
nsHTMLEditor::HavePrivateHTMLFlavor(nsIClipboard *aClipboard,
                                    PRBool* aReturn)
{
  *aReturn = PR_FALSE;
   NS_ENSURE_ARG_POINTER(aClipboard);
   
   nsCOMPtr<nsISupportsArray> flavArray;
   nsresult res = NS_NewISupportsArray(getter_AddRefs(flavArray));
   if (NS_FAILED(res)) 
     return res 
   nsCOMPtr<nsISupportsCString> contextString(   
do_CreateInstance(NS_SUPPORTS_CSTRING_CONTRACTID, &res));
   if (contextString)
     contextString->SetData(NS_LITERAL_CSTRING(kHTMLContext));
     ...
   }
....
}

Comment 1

[Chris Peterson [:cpeterson]]

HavePrivateHTMLFlavor() now returns bool and no longer tries to return an nsresult as a PRBool.