Closed Bug 1852475 Opened 1 year ago Closed 1 year ago

Multiple icons contained in a single tiled image: access is broken

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

Firefox 115
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: sendion23-ux, Unassigned)

Details

Attachments

(1 file)

Attached image customize_toolbar.jpg

Steps to reproduce:

Here is the best way to demonstrate the problem:

  1. In Firefox put "about:support" in the address bar (without the quote marks) and push the Enter or Return key.
  2. On Windows: To the right of "Profile Folder" click on "Open Folder"
  3. Now open an existing "chrome" folder or make a new one and open it.
  4. Set your operating system to display files and file extensions which are hidden by default on Microsoft Windows.
  5. If a "userChrome.css" file exists, rename it to something else, such as "my_userChrome.css".
  6. If a "userContent.css" file exists, rename it to something else, such as "my_userContent.css".
  7. Download and unzip the http://www.mw.rat.bz/foxscapeuc/FOXSCAPEuC%202021-03-06%20v7%20Fx85.0.zip file into the chrome folder.
  8. In Firefox put "about:config" in the address bar (without the quote marks) and push the Enter or Return key.
  9. If you get a screen stating "This might void your warranty!", then click on the "I accept the risk!" button.
  10. On the about:config page, put toolkit.legacyUserProfileCustomizations.stylesheets in the Search: field at the top of the page.
  11. If the value column has false in it, double click false to make it show true. Otherwise, go to the next step.
  12. Close the about:config page.
  13. Restart Firefox by going to "about:profiles" and by clicking on the "Restart normally..." button.

Actual results:

After the restart:

  1. The toolbar occupies 9 rows instead of 1 row.
  2. In the "Customize Toolbar . . ." mode, I cannot drag individual icons. Instead, I may drag a set of icons enclosed in a read rectangle (see the attached snapshot).
  3. In the "Customize Toolbar . . ." mode, I cannot drop icons.

Note that I am able to reproduce this behaviour on both:

  • User agent: Mozilla/5.0 (Windows NT 6.1; rv:109.0) Gecko/20100101 Firefox/115.0
  • User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0

Expected results:

After the restart:

  1. The toolbar should occupy 1 row.
  2. In the "Customize Toolbar . . ." mode, I should be able to drag individual icons.
  3. In the "Customize Toolbar . . ." mode, I should be able to drop individual icons.

Note that everything works as expected in v103.0.2 of Firefox.

Additional information

I went through the Release Notes from v103.0.2 through 113.0.1. None of the release notes stipulates that you cannot have multiple icons contained in a single tiled image.

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: ImageLib' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Graphics: ImageLib
Product: Firefox → Core

Can you use https://mozilla.github.io/mozregression/ to determine which changeset caused this?

Alternatively, can you come up with a much simpler/smaller testcase that demonstrates the problem?

Flags: needinfo?(sendion23-ux)

Can you use https://mozilla.github.io/mozregression to determine which changeset caused this?

No, I cannot. I am afraid that the installation and/or execution of https://mozilla.github.io/mozregression may interfere with the current installation and/or customization of Firefox, and cause more damage. Sorry, I cannot risk the given machine to go down once more.


can you come up with a much simpler/smaller testcase that demonstrates the problem?

At the moment, I don't have free cycles to work on the downsizing of a testcase. Nevertheless , I can provide more details in order to point you to the right direction.

As the bug tittle says, "multiple icons are contained in a single tiled image". For instance, take a look at <profile folder>/chrome/foxscapeuc/z-main/myToolbar.png. This image contains about 65 icons. The access to individual icons is implemented in <profile folder>/foxscapeuc/sub/navigation_toolbar_main_bitmapped_buttons_skinned.css:

/* forward button 24px touch */
:root[uidensity=touch] #forward-button .toolbarbutton-icon {
  list-style-image: url("./../z-main/myToolbar.png") !important;
}
:root[uidensity=touch] #forward-button {
  -moz-image-region: rect(0px 48px 24px 24px) !important;
}
:root[uidensity=touch] #forward-button:not([disabled="true"]):hover {
  -moz-image-region: rect(24px 48px 48px 24px) !important;
}
:root[uidensity=touch] #forward-button[disabled="true"] {
  -moz-image-region: rect(48px 48px 72px 24px) !important;
}
:root[uidensity=touch] #forward-button:not([disabled="true"]):hover:active {
  -moz-image-region: rect(96px 48px 120px 24px) !important;
}

I hope, the Firefox/Mozilla Test Suite (on your end) already covers the backward compatibility aspect of such a capability (i.e. the access to individual icons).

Flags: needinfo?(sendion23-ux)
Component: Graphics: ImageLib → Layout: Images, Video, and HTML Frames

mozregression doesn't touch your firefox profile or the install dir for firefox, it's completely separate, thats pretty much a fundamental requirement of mozregression.

Hi - I noticed that you're using -moz-image-region. That has been removed from Firefox since 112.

The sprite use case is still supported by the standard CSS properties background-size and background-position - as done here.

Status: UNCONFIRMED → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: