Closed Bug 1852535 Opened 1 year ago Closed 1 year ago

‘Thanks for your feedback’ string missing punctuation( full stop) after dismissing an Add-on suggestion with ‘Show less frequently’ option

Categories

(Firefox :: Address Bar, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: oardelean, Assigned: daisuke)

Details

Attachments

(1 file, 1 obsolete file)

Notes

  • Screenshot attached;
  • Suggesting S4 severity;

Found in

  • Beta 118.0b7;

Affected versions

  • Nightly 119.0a1;
  • Beta 118.0b7;

Tested platforms

  • macOS 12;
  • Windows 10;
  • Ubuntu 22;

Affected platforms

  • macOS 12;
  • Windows 10;
  • Ubuntu 22;

Unaffected platforms

  • N/A;

Preconditions

  • browser.urlbar.quicksuggest.enabled set to true
  • browser.urlbar.addons.featureGate set to true
  • browser.search.region set to US

Steps to reproduce

  1. Launch Firefox with the profile from the preconditions.
  2. In the Address Bar type a keyword that would trigger an Add-on recommendation, such as ‘tts’ , ‘adblock’ , ‘videos’.
  3. Once the Add-on recommendation is shown, click on the ‘Feedback’ button.
  4. Click on ‘Show less frequently’.

Expected result

  • ‘Thanks for your feedback.’ string is shown, with punctuation(full stop).

Actual result

  • ‘Thanks for your feedback’ string is shown, without punctuation(full stop).

Regression range

  • Not a regression, bug exists since the Add-on feature was first implemented.

:oardelean, if you think that's a regression, could you try to find a regression range using for example mozregression?

I don't have access to the mockup, should the sentence end with a period Daisuke?

Flags: needinfo?(daisuke)

I'm so sorry for my late response!
It seems that the following message is the cause.
https://searchfox.org/mozilla-central/rev/c56cc57d547a5febcc34160e581f9d58c0326aa7/browser/components/urlbar/content/enUS-searchFeatures.ftl#63
I will fix it.

Flags: needinfo?(daisuke)
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Let's get clarity with Brent before we do this.

Priority: -- → P3

We got the answer from Brent.

When it says “Thanks for your feedback” — no punctuation.
When it says “Thanks for your feedback. You won’t see this again.” — there should be punctuation.
For reference: End punctuation guidance via Product Content guidelines

So, as it seems that we don't need punctuation here, I close this bug.
Thank you very much for your report, Ardelean!

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
Attachment #9353846 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: