Closed Bug 1852545 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 41834 - [FedCM] Update wpt tests for AccountAutoSelectedFlag API

Categories

(Core :: DOM: Credential Management, task, P4)

task

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41834 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41834
Details from upstream follow.

Yi Gu <yigu@chromium.org> wrote:

[FedCM] Update wpt tests for AccountAutoSelectedFlag API

The feature is enabled in test so we should be able to query the boolean
directly. Similar to other FedCM features, the actual exposure of the
API to web content is controlled by the flag in RuntimeEnabledFeatures
on the blink side. Currently the feature is only enabled in tests.

This patch also fixed an issue where the browser process would return
the value even if the feature is disabled.

Change-Id: Iba2a555bc66fd052d140de88d039e23327f249cb
Bug: 1473976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845249
Reviewed-by: Nicolás Peña \<npm@chromium.org>
Reviewed-by: John Abd-El-Malek \<jam@chromium.org>
Commit-Queue: Yi Gu \<yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194808}

Component: web-platform-tests → DOM: Credential Management
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

ERROR : 1

Chrome

TIMEOUT: 2

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /credential-management/fedcm-account-auto-selected-flag.https.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: TIMEOUT, Safari: OK)

Tests Disabled in Gecko Infrastructure

  • /credential-management/fedcm-account-auto-selected-flag.https.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: TIMEOUT, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f79081bfbe6 [wpt PR 41834] - [FedCM] Update wpt tests for AccountAutoSelectedFlag API, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.