1852599 - [wpt-sync] Sync PR 41913 - Handle OOFs in spanners within NGOutOfFlowLayoutPart::ReplaceFragment

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41913 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41913
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

Handle OOFs in spanners within NGOutOfFlowLayoutPart::ReplaceFragment

When we find an OOF in the CB path within
NGOutOfFlowLayoutPart::ReplaceFragment(), we end up looking for the
next viable fragmentation context root to search for its fragment(s).
However, if there is a spanner in the CB path (as a result of
CL:3343283), that OOF will propagate up to the next context since
spanners are not laid out in their immediate multicol parent.

Thus, we will need to continue up the tree in such cases in
NGOutOfFlowLayoutPart::ReplaceFragment() in order to properly find
the OOF ancestor in question.

Bug: 1479320
Change-Id: I88ffa3094f26c06cebc4bbe32a59e41ad77fe763
Reviewed-on: https://chromium-review.googlesource.com/4854084
WPT-Export-Revision: 0aec2f58c14d134fab52682beff7b0b3724b3c4e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=03e7eb75ed11317b476326b87422dc23227dd1c5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=089849d6d14e1272232e726461502cd582dd470a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d788b7a3234c
[wpt PR 41913] - Handle OOFs in spanners within NGOutOfFlowLayoutPart::ReplaceFragment, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d788b7a3234c