1852778 - Title bar is barely visible in Customize mode if system theme is set to dark

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: title bar customize mode.png

Found in

• Firefox 119.0a1

Affected versions

• Firefox 119.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 13.5.2
• Unaffected platforms: Ubuntu 22.04

Preconditions

• Have the system theme set to dark

Steps to reproduce

1. Launch Firefox with a clean profile
2. Access customize mode
3. Look over the Title bar option

Expected result

• The Title bar option is visible

Actual result

• The Title bar option is barely visible

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the attachment
• This only happens if the system theme is set to Dark and Firefox has the Auto theme. Will not reproduce if dark is manually selected from Themes within Firefox.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:csasca, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey kcochrane - do you think this is similar to what you experienced with the dark theme on Firefox View?

Comment 3

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Looked for regression and this is what I got in the info panel:
Bug 1843044 - Make the default theme work with dark color schemes. r=dao,pbz

This builds on the light-dark() function added in bug 1845679 to provide
custom colors for both the default light and dark themes, and remove the
"default theme in dark mode" bits.

This is all to be landed after the soft-freeze in any case. Untested on
macOS for now, but no reason it shouldn't work. Will test later today.

On the light theme we were relying on Field / FieldText being black /
white for toolbar-field-focus, so make that explicit too:

InspectorUtils.colorToRGBA("Field", document) // Object { a: 1, b: 255, g: 255, r: 255 }
InspectorUtils.colorToRGBA("FieldText", document) // Object { a: 1, b: 0, g: 0, r: 0 }.

Comment 4

[Kelly Cochrane [:kcochrane]]

mconley, yeah it looks like this was caused by the same patch that affected dark mode in Firefox View! I've written that up in bug 1852603. In our case, we were previously able to access --newtab variables from Firefox View using styles applied to the :root element in contentTheme.js. After bug 1843044, we know longer get access to those variables, so our page background is falling back to --in-content-page-background which looks much too dark in dark mode. The theming on Firefox View should match the new tab page. Let me know if I can be of any more help here!

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1843044

:emilio, since you are the author of the regressor, bug 1843044, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1852778 - Proposal 1: Remove non-color-scheme-respecting platform-specific CSS for customize mode buttons. r=#desktop-theme-reviewers

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1852778 - Proposal 2: Only set light color for customization checkbox in the default light theme. r=#desktop-theme-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f36682c7da0
Proposal 1: Remove non-color-scheme-respecting platform-specific CSS for customize mode buttons. r=desktop-theme-reviewers,dao

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9f36682c7da0

Comment 10

[Anca Soncutean, Desktop QA]

Reproduced with Fx 119.0a1 (2023-09-12) on Windows 10 .
Verified fixed with Fx 120.0a1(2023-10-01) and Fx 119.0b3 on Windows 10, macOS 13 and Ubuntu 22..