1853021 - 30.02 - 15.88% google-mail fcp / google-mail fcp (Linux) regression on Fri September 8 2023

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a browsertime performance regression from push 49a63f05dc66f416debbf9b5ff93cedbcbe553c2. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
30%	google-mail fcp	linux1804-64-shippable-qr	cold fission webrender	507.30 -> 659.59	Before/After
16%	google-mail fcp	linux1804-64-shippable-qr	cold fission webrender	540.05 -> 625.83	Before/After

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
6%	espn ContentfulSpeedIndex	windows10-64-shippable-qr	cold fission webrender	862.06 -> 809.72
3%	cnn-nav.world loadtime	windows10-64-shippable-qr	cold fission webrender	875.59 -> 853.60

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1852072

Comment 2

[Jan Varga [:janv]]

If the regression is really related to bug 1852072, we can add an early check to IsUUIDOrigin implementation:

if (!StringBeginsWith(aOrigin, kUUIDOriginScheme) {
  return false;
}

Comment 3

[Harveer Singh]

Regression is looking really bad and it's very unlikely that it could have caused by the linked commits. But the shortcut suggested by :janv above is easy and should improve performance so, I decided to create a patch for it shortly.

Comment 4

[Harveer Singh]

Attachment: Bug 1853021: Fixing a potential performance regression caused by Bug1852071.r=janv,#dom-storage-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc5263806a3f
Fixing a potential performance regression caused by Bug1852071.r=janv,dom-storage-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dc5263806a3f

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc5263806a3f
Fixing a potential performance regression caused by
Bug1852071.r=janv,dom-storage-reviewers

== Change summary for alert #39557 (as of Fri, 15 Sep 2023 06:07:57 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
17%	google-mail fcp	linux1804-64-shippable-qr	cold fission webrender	618.92 -> 512.60	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39557