Cmd+Shift+F does not focus Project Search input if it was already opened
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Not tracked)
People
(Reporter: nchevobbe, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
Steps to reproduce
- Open the debugger
- Hit Cmd+Shift+F (Ctrl+Shift+F on other OSes) to open project search UI
- Click somewhere else so the focus is not on the search input anymore
- Hit the keyboard shortcut again
Expected results
The search input gets focused again
Actual results
It does not get focused
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
This issue starts from there:
https://searchfox.org/mozilla-central/rev/7499890dc8f116a9e40f4a689a251a0311a9f461/devtools/client/debugger/src/components/App.js#135-139
The call to setActiveSearch action wouldn't force to re-focus as the project search is already displayed.
May be the ProjectSearch component should also register a key shortcut like this:
https://searchfox.org/mozilla-central/rev/7499890dc8f116a9e40f4a689a251a0311a9f461/devtools/client/debugger/src/components/App.js#102-105
On register it over there:
https://searchfox.org/mozilla-central/rev/7499890dc8f116a9e40f4a689a251a0311a9f461/devtools/client/debugger/src/components/PrimaryPanes/ProjectSearch.js#73-81
So that we refocus the SearchInput:
https://searchfox.org/mozilla-central/rev/7499890dc8f116a9e40f4a689a251a0311a9f461/devtools/client/debugger/src/components/PrimaryPanes/ProjectSearch.js#310-341
Description
•