Closed Bug 1853313 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 41931 - Make MediaStreamTrack Stats API synchronous (WebIDL).

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox120 fixed)

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
firefox120 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41931 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41931
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:

Make MediaStreamTrack Stats API synchronous (WebIDL).

In accordance with
https://github.com/w3c/mediacapture-extensions/pull/106, we should
synchronously return the frame counters to JavaScript rather than
returning a promise that is resolved with the frame counters.

This CL updates WebIDL, blink implementation and WPTs accordingly.

The run-to-completion is still not implemented (caching if the getter
is called multiple times in the same task execution cycle), but that
is easier to add in a follow-up CL.

Bug: chromium:1472978
Change-Id: Ieaf8bc902864ddbc12fbb3b00225836e1750f30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4858239
Commit-Queue: Henrik Boström \<hbos@chromium.org>
Reviewed-by: Tony Herre \<toprice@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1195916}

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
FAIL: 11[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 12[GitHub]

Chrome

OK : 1
FAIL: 12

Safari

OK : 1
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /mediacapture-extensions/MediaStreamTrack-video-stats.https.html [wpt.fyi]
    • totalFrames increases over time: FAIL (Chrome: FAIL, Safari: FAIL)
    • deliveredFrames increases, even without sinks: FAIL (Chrome: FAIL, Safari: FAIL)
    • discardedFrames increases when frameRate decimation is happening: FAIL (Chrome: FAIL, Safari: FAIL)
    • totalFrames is the sum of deliveredFrames and discardedFrames: FAIL (Chrome: FAIL, Safari: FAIL)
    • SameObject policy applies: FAIL (Chrome: FAIL, Safari: FAIL)
    • Stats are frozen while disabled: FAIL (Chrome: FAIL, Safari: FAIL)
    • Disabling and re-enabling does not reset the counters: FAIL (Chrome: FAIL, Safari: FAIL)
    • New stats baselines when a track is cloned from a disabled track: FAIL (Chrome: FAIL, Safari: FAIL)
    • New stats baselines when a track is cloned from an enabled track: FAIL (Chrome: FAIL, Safari: FAIL)
    • New stats baselines for the clone of a clone: FAIL (Chrome: FAIL, Safari: FAIL)
    • getFrameStats throws on audio tracks: FAIL (Chrome: FAIL, Safari: FAIL)
    • A low FPS clone does not affect the original track's discardedFrames: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2455c1307312 [wpt PR 41931] - Make MediaStreamTrack Stats API synchronous (WebIDL)., a=testonly

https://hg.mozilla.org/mozilla-central/rev/2455c1307312

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox120: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.