18534 - dialogs should say Yes/No, not OK/Cancel

Status: VERIFIED DUPLICATE of bug 13228

(Toolkit :: Form Manager, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  The wallet dialogs that ask about whether you want to save the
data submitted on a form should say yes/no, not ok/cancel.  In particular, I see
the following two dialogs:

Do you want to save the username and password for this form?
                    OK         Cancel


Remember this decision for this site?
             OK   Cancel


These dialogs are asking yes/no questions.  OK/Cancel is confusing, since cancel
makes one think that the entire form submission will be cancelled (which is not
the case).

STEPS TO REPRODUCE:
 * go to www.deja.com
 * click "My Deja" somewhere in the upper left
 * click "Login" in the top middle of the main text
 * fill in some values
 * click submit

ACTUAL RESULTS:
 * Dialogs as described above.

EXPECTED RESULTS:
 * Yes/No buttons on the dialogs.

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-11-10-08-M12

Comment 1

[Stephen P. Morse]

There are several other dialogs as well that are supposed to be yes/no rather
than ok/cancel.  And for a brief period of time they were ok/cancel but that
caused us a problem (see bug 13032).  So to avoid those problems, the yes/no
dialog handlers in nsCookie.cpp, wallet.cpp, and singsign.cpp are cheating and
temporarily calling davidm's ok/cancel dialogs instead.

A bug report was opened on the need for true yes/no dialogs (bug 13228) so this
bug is being marked as a dup of that one.

*** This bug has been marked as a duplicate of 13228 ***