1853427 - mach test no longer works for wpt tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Julian Descottes [:jdescottes]]

I get this error every time I try to run wdspec tests locally:

TypeError: wptrunner.browsers.firefox.executor_kwargs() got multiple values for keyword argument 'subsuite'

STRs:

• run ./mach test testing/web-platform/tests/webdriver/tests/bidi/browsing_context/user_prompt_closed/user_prompt_closed.py

Note that ./mach wpt still works, only the ./mach test shortcut is broken

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Isn't that actually bug 1849754 which regressed it? Bug 1849951 doesn't show any changes in this call stack.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849951

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #1)

Isn't that actually bug 1849754 which regressed it? Bug 1849951 doesn't show any changes in this call stack.

Uh good catch. Not sure how I came up with the other bug number, the bisect did point to 1849754

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

James given that you are the original author of the regressor, could you please have a look?

Comment 5

[James Graham [:jgraham]]

Attachment: Bug 1853427 - Remove subsuite argument when invoked via mach test,

Unfortunately mach test makes unverified assumptions about the top
level kwargs of all test suites. This broke wpt because it was passing
around a subsuite argument that was previously ignored, but recently
caused a conflict in functions with signatures like
function(subsuite, **kwargs).

Fow now just remove the argument in the part of the wpt frontend that
handles data expected to be from mach test.

Comment 6

[James Graham [:jgraham]]

Attachment: Bug 1853427 - Don't call shutdown() on a already shutdown logger,

mach test was unconditionally calling shutdown() on the logger,
which doesn't work if the harness (reasonably) already shut down the
logger itself. Add a new property to check if the logger has been shut
down, and check it before calling shutdown.

Comment 7

[James Graham [:jgraham]]

See attached patches.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be2a2dbdf656
Remove subsuite argument when invoked via mach test, r=Sasha
https://hg.mozilla.org/integration/autoland/rev/5baf76c5d8f1
Don't call shutdown() on a already shutdown logger, r=ahal

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/be2a2dbdf656
https://hg.mozilla.org/mozilla-central/rev/5baf76c5d8f1