1853597 - unswitch loop over AudioParam values for a single event

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement)

Description

[Karl Tomlinson (:karlt)]

From bug 1184057 comment 1:

We should determine, in the 128 ticks block, the boundaries for which to compute which event, and then compute the actual values in one pass after

Comment 1

[Karl Tomlinson (:karlt)]

Unswitching the loop over AudioParam values for a single event improves performance by 24 - 30% on Granular synthesis, 17 - 28% on Substractive synth, 12 - 16% on Periodic Wave with Automation, and 5 - 16% on Stereo Panning with Automation. Those results do not include changes for bug 1171441, but some of those improvements would also be provided by fixing that bug. i.e. Not all of these benchmark improvements are additional to those from fixing bug 1171441, but unswitching the loops also helps with bug 1851755, and these results show that unswitching makes a big difference on some workloads.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1853597 simplify initial and final SetValueCurve value calculations r?padenot

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1853597 unswitch loop over AudioParam values for a single event r?padenot

The differences in biquad-automation.html results are because
v1 - v0 is now calculated in double precision.

Depends on D189100

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02eea545be15
simplify initial and final SetValueCurve value calculations r=padenot

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1853597 annotate bug tracking BiquadFilterNode a-rate automation failure r?padenot

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b04d04a848ba
annotate bug tracking BiquadFilterNode a-rate automation failure r=padenot

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/02eea545be15

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf5fe9331b89
unswitch loop over AudioParam values for a single event r=padenot

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b04d04a848ba

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cf5fe9331b89