1853598 - fetch whole block of OscillatorNode AudioParam values at once

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement)

Description

[Karl Tomlinson (:karlt)]

This saves 11-18% on the Periodic Wave with Automation benchmark and 6-12% on Substractive synth, and further improvements should be possible with bug 1853597.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1853598 clarify that no silence OscillatorType exists r?padenot

Converting an ECMAScript value an IDL enumeration type throws if the string is
not one of the enumeration values.
https://webidl.spec.whatwg.org/#es-enumeration

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1853598 fetch whole block of OscillatorNode AudioParam values at once r?padenot

Depends on D188433

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1853598 remove now unused AudioParamTimeline::GetValueAtTime(aTime, aCounter) r?padenot

GetValuesAtTime() is more appropriate on the rendering thread and non-zero
aCounter was already unsupported on the control thread.

Depends on D188434

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1853598 remove unused control thread / double TimeType GetValuesAtTime() r?padenot

aSize > 1 was not supported.
https://searchfox.org/mozilla-central/rev/b741ddde6c678ca7025858952202d20664491555/dom/media/webaudio/AudioEventTimeline.cpp#127

Depends on D188435

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0bc4d3dab8a
clarify that no silence OscillatorType exists r=padenot
https://hg.mozilla.org/integration/autoland/rev/82a51fd41a66
fetch whole block of OscillatorNode AudioParam values at once r=padenot

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b2d3bd59737
remove now unused AudioParamTimeline::GetValueAtTime(aTime, aCounter) r=padenot
https://hg.mozilla.org/integration/autoland/rev/68879cdd20f5
remove unused control thread / double TimeType GetValuesAtTime() r=padenot

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d0bc4d3dab8a
https://hg.mozilla.org/mozilla-central/rev/82a51fd41a66
https://hg.mozilla.org/mozilla-central/rev/3b2d3bd59737
https://hg.mozilla.org/mozilla-central/rev/68879cdd20f5