1853619 - Undefined symbol _ZNK17double_conversion23StringToDoubleConverter14StringToDoubleEPKtiPi

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Petr Sumbera]

Steps to reproduce:

I see following error on SPARC Solaris (not i386!):

61:44.90 Undefined                      first referenced
61:44.90  symbol                            in file
61:44.91 _ZNK17double_conversion23StringToDoubleConverter14StringToDoubleEPKtiPi /builds2/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/config/external/icu/i18n/host_number_decimalquantity.o
61:44.91 _ZNK17double_conversion23StringToDoubleConverter14StringToDoubleEPKciPi /builds2/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/config/external/icu/i18n/host_units_converter.o
61:44.91 _ZN17double_conversion23DoubleToStringConverter13DoubleToAsciiEdNS0_8DtoaModeEiPciPbPiS4_ /builds2/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/config/external/icu/i18n/host_number_decimalquantity.o
61:44.91 ld: fatal: symbol referencing errors
61:44.99 collect2: error: ld returned 1 exit status
61:45.00 gmake[4]: *** [/builds2/psumbera/mozilla-central-build/config/rules.mk:437: ../../../../dist/host/bin/icupkg] Error 1
61:45.01 gmake[3]: *** [/builds2/psumbera/mozilla-central-build/config/recurse.mk:72: config/external/icu/icupkg/host] Error 2
61:45.01 gmake[3]: *** Waiting for unfinished jobs....

The first bad revision is:
changeset: 678235:342715c534a9
user: serge-sans-paille <[e-mail]>
date: Fri Sep 15 01:27:43 2023 -0700
description:
Bug 1852210 - Remove duplicate double_conversion sources r=dminor

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sergesanspaille, since you are the author of the regressor, bug 1852210, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[[:sergesanspaille]]

How strange... which configure flags are you using? Could you do a clean rebuild with mach build -v and share the output (you can grab it through mach show-log > build.log)

Comment 4

[Petr Sumbera]

There is probably some problem with show-log on Solaris?! It ends like this:

FileNotFoundError: [Errno 2] No such file or directory: '/builds2/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/.mozbuild/last_log.json'

  File "/builds2/psumbera/mozilla-central-build/python/mozbuild/mozbuild/mach_commands.py", line 599, in show_log
    log_file = open(path, "rb")

I tried to attache build output but I'm getting an error as the file is probably too big (9.46MiB).

Note also that tha problem is only seen on SPARC - big endian platform.

Comment 5

[Mike Hommey [:glandium] OoO until Jun 18]

To reproduce on little endian: remove all conditionals related to TARGET_ENDIANNESS in config/external/icu/common/moz.build, config/external/icu/data/moz.build, config/external/icu/i18n/moz.build and config/external/icu/moz.build

Comment 6

[Dan Horák]

for the record, seen on Fedora/s390x too

Comment 7

[Mike Hommey [:glandium] OoO until Jun 18]

Attachment: Bug 1853619 - Build double-conversion for icupkg on big endians.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1852210

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e54e1c7d443b
Build double-conversion for icupkg on big endians. r=sergesanspaille

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e54e1c7d443b