1853653 - `mach buildsymbols` should explain that it aborted because crash reporter is not enabled

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

When I use the mach buildsymbols locally on a desktop setup, it runs without a problem and I haven't had this issue there before.

But last week I wanted to run buildsymbols again in Firefox for Android build this time. Apparently crash reporter is not enabled by default there on local builds. That's why when I run this command, it silently failed, here's the console output:

  Parallelism determined by memory: using 10 jobs for 10 cores based on 64.0 GiB RAM and estimated job size of 1.0 GiB
 0:00.10 /usr/bin/make -C . -j10 -s -w buildsymbols

I was a bit surprised by this because it just aborted without any additional context. I had to find the buildsymbols rule to see what's going on. Apparently this is because there weren't MOZ_CRASHREPORTER and MOZ_ENABLE_FULL_SYMBOLS defined.

It would be nice to print an info message about what's happening.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1853653 - Explain why `mach buildsymbols` is skipped r?#build

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfb13a0cd703
Explain why `mach buildsymbols` is skipped r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bfb13a0cd703