[wpt-sync] Sync PR 42002 - [text-autospace] Fix for ligatures
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox120 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 42002 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/42002
Details from upstream follow.
Koji Ishii <kojii@chromium.org> wrote:
[text-autospace] Fix for ligatures
This patch fixes
text-autospacing
not being applied after
ligatures.To fix this:
NGTextAutoSpace
is changed to use the offset to insert
auto-spacing before, not after.ShapeResult::ApplyTextAutoSpacing
is changed to add the
spacing to the last glyph before the offset is equal to or
greater than the specified offset.Note,
AddAutoSpacingToIdeographRTL
was removed because it
fails with this change, and the RTL implementation is being
re-worked out.Bug: 1463890
Change-Id: I260539ff4bebf14e894854d033bf10b6fc52f054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4863019
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Lingqi Chi \<lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1197168}
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Assignee | ||
Comment 2•1 year ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 1 subtests
Status Summary
Firefox
OK
: 1
FAIL
: 1
Chrome
OK
: 1
FAIL
: 1
Safari
OK
: 1
FAIL
: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-text/text-autospace/text-autospace-ligature-001.html [wpt.fyi]
- text-autospace not implemented:
FAIL
(Chrome:FAIL
, Safari:FAIL
)
- text-autospace not implemented:
Comment 4•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3918aad24b3a
https://hg.mozilla.org/mozilla-central/rev/cc9d87d1eb4d
Description
•