Closed Bug 1853814 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42017 - LoAF: Expose script URL for promise resolvers

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox120 fixed)

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42017 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42017
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

LoAF: Expose script URL for promise resolvers

Capture the current script URL when constructing a
promise resolver (e.g. calling fetch()), and read
it when the promise resolver is invoked (e.g.
the response is being processed).

Confirmed with the V8 team that this should (in theory)
have acceptable overhead, as GetCurrentScriptUrl() is
called only in places that are "heavy" to begin with,
like invoking a new fetch or calling a platform API.

Change-Id: I2c81a3694849bd73f0986f19f3de752093f6d7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4802170
Reviewed-by: Yoav Weiss \<yoavweiss@chromium.org>
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1197775}

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 3
FAIL : 1

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/e17cdca58f77 [wpt PR 42017] - LoAF: Expose script URL for promise resolvers, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.