1853832 - Remove dom.mouseevent.click.hack.use_legacy_non-primary_dispatch pref

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Gregory Pappas [:gregp]]

This is an override pref to restore legacy non-primary click dispatch behavior on specific domains. It's been empty since being introduced about 5 years ago in bug 1379466.

Is it ok to remove this pref now?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If it's not used in organizations, yes, I think that we can drop it. Even if we collect the usage data, I guess organizations may disable telemetry, so, I'm not sure how do we consider this kind of cases.

Comment 2

[Gregory Pappas [:gregp]]

Should we add telemetry for how many installations have a non-empty value for this pref?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that adding telemetry to collect the usage is the right way in strictly speaking, but I guess that it does not indicate the actual usage in this case because of the reason mentioned in comment 1. So I think that just removing the pref may be allowed.

Smaug, WDYT?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I think we should try to just remove the pref

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you. Then, let's watch the feedback from testers after removing the pref.

Comment 6

[Gregory Pappas [:gregp]]

Attachment: Bug 1853832 - Remove dom.mouseevent.click.hack.use_legacy_non-primary_dispatch pref r?masayuki!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25e26541f18f
Remove dom.mouseevent.click.hack.use_legacy_non-primary_dispatch pref r=masayuki

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/25e26541f18f