Closed Bug 1853968 Opened 3 years ago Closed 3 years ago

2.91 - 1.95% tsvgx / tsvgx (Linux) regression on Wed September 13 2023

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox117 --- unaffected
firefox118 --- unaffected
firefox119 --- wontfix
firefox120 --- wontfix

People

(Reporter: aglavic, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a talos performance regression from push 2533739a555baff2c5e913e1a3d358d3e9f28bd0. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
3% tsvgx linux1804-64-shippable-qr e10s fission stylo webrender-sw 267.27 -> 275.05
2% tsvgx linux1804-64-shippable-qr e10s fission stylo webrender-sw 268.62 -> 273.87

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(acreskey)

Set release status flags based on info from the regressing bug 1843384

status-firefox117: --- → unaffected
status-firefox118: --- → unaffected
status-firefox119: --- → affected
status-firefox-esr102: --- → unaffected
status-firefox-esr115: --- → unaffected

Hmm, definitely not expected because the modified code is only run on shutdown.

But let me have a look.

Andrej, I don't think revision 2533739a555baff2c5e913e1a3d358d3e9f28bd0 caused this regression.

If go to the alert summary and look into the subtests, then there are no tests with significant differences (I added more jobs because some only had 1-4).

And on a fresh try-push comparing baseline to my patch from bug 1843384, I also don't see any regression on this test:

Can you have a look?

Flags: needinfo?(acreskey) → needinfo?(aglavic)

I had a closer look at the graph and agree, not sure how I came to the conclusion I did
Thank you for your patience and sorry for any inconveniences
Leaving need info on to remind myself to find real culprit

Set release status flags based on info from the regressing bug 1843384

status-firefox120: --- → affected

Incorrectly culprit commit has been identified and a bug filed, closing this bug as invalid

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(aglavic)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.