1854009 - Use load32 in call_indirect signature check for subtype depth

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P2)

Description

[Ryan Hunt [:rhunt] (PTO Sept 7-11)]

Only affects the GC proposal. We use load8, when the field is actually 32-bits. With our current limits for GC types, this should not in practice be an issue.

Comment 1

[Ryan Hunt [:rhunt] (PTO Sept 7-11)]

Attachment: Bug 1854009 - wasm: Use load32 for loading subtyping depth. r?bvisness

The subtyping depth field on STV is 32-bits, we should use load32.

The hardcoded subtyping depth limit and LEB byte order currently
save us here, but we shouldn't rely on that.

Comment 2

[Ryan Hunt [:rhunt] (PTO Sept 7-11)]

Attachment: Bug 1854009 - wasm: Use load32 for loading subtyping depth. r?bvisness

The subtyping depth field on STV is 32-bits, we should use load32.

The hardcoded subtyping depth limit and LEB byte order currently
save us here, but we shouldn't rely on that.

Depends on D188303

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/644a53a027f5
wasm: Use load32 for loading subtyping depth. r=bvisness

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/644a53a027f5