1854203 - [wpt-sync] Sync PR 42031 - [DL] Ensure grid placement data is dirty.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42031 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42031
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[DL] Ensure grid placement data is dirty.

After:
https://chromium-review.googlesource.com/c/chromium/src/+/4859555

We started to return nullptr from NGBlockNode::FirstChild. This works
but grid has an additional placement cache which depends on if we
have a first child or not.

Invalidate the placement cache when the display lock context marks
a node for layout.

Bug: 1482765, 1482771
Change-Id: I3a47a192f938c4c14b3c2d1a868d78e30765c3db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4875138
Reviewed-by: Morten Stenshorne \<[e-mail]>
Reviewed-by: Alison Maher \<[e-mail]>
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1198308}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=599ab66eae5a0cfe15c33b4bb773c206ca1e3b02

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/0bbd07920d00
[wpt PR 42031] - [DL] Ensure grid placement data is dirty., a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0bbd07920d00