Closed Bug 1854209 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 41994 - [HighlightPseudos] Fix tests on Mac

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41994 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41994
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

[HighlightPseudos] Fix tests on Mac

The code for resolving highlight colors is updated to
use the correct previous_layer_color for non-Color
properties. The test was failing on Mac because
Mac does not have default theme selection colors.

Other tests have fuzzy matching added to account for
minor pixels diffs on Mac.

All expectations are updated.

Bug: 1433592,1351020
Change-Id: I9692704894615fd497832a133cc8e3f5b7655699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864002
Commit-Queue: Stephen Chenney \<schenney@chromium.org>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1198416}

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core
Test result changes from PR not available.
Pushed by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/9718c86c5dba [wpt PR 41994] - [HighlightPseudos] Fix tests on Mac, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.