Closed Bug 1854213 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42055 - Revert "view-transition: Fix for scrollbar-gutter"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox120 fixed)

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
firefox120 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42055 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42055
Details from upstream follow.

David Bokan <bokan@chromium.org> wrote:

Revert "view-transition: Fix for scrollbar-gutter"

This reverts commit 82850ef24c9745beaea1c60fc08c132a2600b866.

Reason for revert: Need to update fuzz expectation for merge

Original change's description:

view-transition: Fix for scrollbar-gutter

scrollbar-gutter on the left (and top) side causes a divergence between
frame and fixed coordinates, similar to how a scrollbar does. This CL
replaces the logic for LeftHandSideVerticalScrollbars with a more
generic approach that works for both.

Bug: 1478653
Change-Id: I1b92c55fd896f6be7d44daefd8b058ad20b5d75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4863881
Reviewed-by: Khushal Sagar \<khushalsagar@chromium.org>
Commit-Queue: David Bokan \<bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1197155}

Bug: 1478653
Change-Id: Ie39e3dffb36082c61efe9865e23e5ff8479b6bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4877114
Commit-Queue: David Bokan \<bokan@chromium.org>
Reviewed-by: Vladimir Levin \<vmpstr@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1198518}

PR 42055 applied with additional changes from upstream: e298709f319fcd50e268b211145256537928d1b6
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Pushed by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/154da8f91bf5 [wpt PR 42055] - Revert "view-transition: Fix for scrollbar-gutter", a=testonly

https://hg.mozilla.org/mozilla-central/rev/154da8f91bf5

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox120: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.