Closed Bug 1854267 Opened 2 years ago Closed 2 years ago

Perma toolchain custom-car ../../content/browser/media/capture/desktop_capture_device_mac.cc:76:11: error: 'kCGDisplayStreamShowCursor' / 'kCGDisplayStreamPreserveAspectRatio' is only available on macOS 13.0 or newer [-Werror,-Wunguarded-availability-new]

Categories

(Testing :: Raptor, defect, P5)

defect

Tracking

(firefox120 fixed)

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kshampur)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fxp])

Attachments

(1 file)

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=429832146&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SfwbS65bTeKDqPOCRDZNEw/runs/0/artifacts/public/logs/live_backing.log


[task 2023-09-20T19:13:07.173Z] [40765/57973] CXX obj/content/browser/browser/desktop_capture_device_mac.o
[task 2023-09-20T19:13:07.173Z] FAILED: obj/content/browser/browser/desktop_capture_device_mac.o 
[task 2023-09-20T19:13:07.173Z] ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/browser/browser/desktop_capture_device_mac.o.d -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_ENABLE_SAFE_MODE=1 -DCR_XCODE_VERSION=1220 -DCR_CLANG_REVISION=\"llvmorg-18-init-4631-gd50b56d1-1\" -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=3e8a3b3c5d497eb7250566a63432046baf95481a -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCONTENT_IMPLEMENTATION -DV8_USE_EXTERNAL_STARTUP_DATA -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_DISABLE_LEGACY_SKSURFACE_METHODS -DSK_DISABLE_LEGACY_GRAPHITE_IMAGE_FACTORIES -DSK_DISABLE_LEGACY_GRAPHITE_IMAGE_METHODS -DSK_DISABLE_LEGACY_SKSURFACE_FACTORIES -DSK_DISABLE_LEGACY_SKSURFACE_FLUSH -DSK_DISABLE_LEGACY_SKSURFACE_AS_IMAGE -DSK_DISABLE_LEGACY_SKSURFACE_DISPLAYLIST -DSK_DISABLE_LEGACY_IMAGE_SUBSET_METHODS -DSK_DISABLE_LEGACY_IMAGE_COLORSPACE_METHODS -DSK_DISABLE_LEGACY_IMAGE_RELEASE_PROCS -DSK_DISABLE_LEGACY_GL_BACKEND_SURFACE -DSK_DISABLE_LEGACY_INIT_DECODERS -DSK_DISABLE_LEGACY_GRDIRECTCONTEXT_FLUSH -DSK_DISABLE_LEGACY_GRDIRECTCONTEXT_BOOLS -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_BUILD_FOR_MAC -DSK_GANESH -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_GL -DSK_GRAPHITE -DSK_DAWN -DWEBP_EXTERN=extern -DUSE_EGL -DLIBYUV_DISABLE_NEON -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DLEVELDB_PLATFORM_CHROMIUM=1 -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DWEBRTC_ENABLE_AVX2 -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DLOGGING_INSIDE_WEBRTC -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_SLIM_WRITE_BARRIER -DSQLITE_OMIT_ANALYZE -DSQLITE_OMIT_AUTOINIT -DSQLITE_OMIT_AUTOMATIC_INDEX -DSQLITE_OMIT_AUTORESET -DSQLITE_OMIT_COMPILEOPTION_DIAGS -DSQLITE_OMIT_EXPLAIN -DSQLITE_OMIT_GET_TABLE -DSQLITE_OMIT_INTROSPECTION_PRAGMAS -DSQLITE_DEFAULT_LOOKASIDE=0,0 -DSQLITE_OMIT_LOOKASIDE -DSQLITE_OMIT_TCL_VARIABLE -DSQLITE_OMIT_REINDEX -DSQLITE_OMIT_TRACE -DSQLITE_OMIT_UPSERT -DSQLITE_OMIT_WINDOWFUNC -DSQLITE_ENABLE_FTS3 -DSQLITE_DISABLE_FTS3_UNICODE -DSQLITE_DISABLE_FTS4_DEFERRED -DSQLITE_ENABLE_ICU -DSQLITE_SECURE_DELETE -DSQLITE_THREADSAFE=1 -DSQLITE_MAX_WORKER_THREADS=0 -DSQLITE_MAX_MMAP_SIZE=268435456 -DSQLITE_DEFAULT_FILE_PERMISSIONS=0600 -DSQLITE_DEFAULT_LOCKING_MODE=1 -DSQLITE_DEFAULT_MEMSTATUS=1 -DSQLITE_DEFAULT_PAGE_SIZE=4096 -DSQLITE_DEFAULT_PCACHE_INITSZ=0 -DSQLITE_LIKE_DOESNT_MATCH_BLOBS -DSQLITE_OMIT_DEPRECATED -DSQLITE_OMIT_PROGRESS_CALLBACK -DSQLITE_OMIT_SHARED_CACHE -DSQLITE_USE_ALLOCA -DSQLITE_OMIT_DECLTYPE -DSQLITE_OMIT_JSON -DSQLITE_OMIT_LOAD_EXTENSION -DSQLITE_HAVE_ISNAN -DSQLITE_HAVE_SQLITE3R -DSQLITE_ENABLE_DBPAGE_VTAB -DSQLITE_ENABLE_BATCH_ATOMIC_WRITE -DSQLITE_TEMP_STORE=3 -DSQLITE_ENABLE_LOCKING_STYLE=1 -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../third_party/skia -Igen/third_party/skia -I../../third_party/wuffs/src/release/c -Igen/third_party/dawn/include -I../../third_party/dawn/include -I../../third_party/libwebp/src/src -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -I../../third_party/khronos -I../../gpu -I../../third_party/libyuv/include -I../../third_party/jsoncpp/source/include -Igen/third_party/private_membership/src -Igen/third_party/shell-encryption/src -Igen/components/policy/proto -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/ipcz/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/libwebm/source -I../../third_party/mesa_headers -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/crashpad/crashpad -I../../third_party/crashpad/crashpad/compat/mac -I../../third_party/crashpad/crashpad/compat/non_win -I../../third_party/zlib -I../../third_party/libaom/source/libaom -Igen/net/third_party/quiche/src -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -Igen/third_party/metrics_proto -I../../v8/include -Igen/v8/include -I../../third_party/brotli/include -I../../third_party/distributed_point_functions -I../../third_party/distributed_point_functions/code -Igen/third_party/distributed_point_functions -I../../third_party/highway/src -I../../third_party/re2/src -Wall -Werror -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -ffp-contract=off -flto=thin -fsplit-lto-unit -fwhole-program-vtables -fcomplete-member-pointers -arch x86_64 -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-omit-frame-pointer -g0 -isysroot ../../../../../fetches/MacOSX13.3.sdk -mmacos-version-min=10.15 -fprofile-use=../../chrome/build/pgo_profiles/chrome-mac-main-1695211116-6e86d9a93df42bc2451a49536c17d168acd2959e.profdata -Wno-profile-instr-unprofiled -Wno-profile-instr-out-of-date -Wno-backend-plugin -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang raw-ref-template-as-trivial-member -Xclang -plugin-arg-find-bad-constructs -Xclang check-stack-allocated -Xclang -plugin-arg-find-bad-constructs -Xclang check-raw-ptr-to-stack-allocated -Xclang -plugin-arg-find-bad-constructs -Xclang raw-ptr-fix-crbug-1449812 -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -DPROTOBUF_ALLOW_DEPRECATED=1 -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -nostdinc++ -isystem../../third_party/libc++/src/include -isystem../../third_party/libc++abi/src/include -fvisibility-inlines-hidden -c ../../content/browser/media/capture/desktop_capture_device_mac.cc -o obj/content/browser/browser/desktop_capture_device_mac.o
[task 2023-09-20T19:13:07.173Z] ../../content/browser/media/capture/desktop_capture_device_mac.cc:76:11: error: 'kCGDisplayStreamShowCursor' is only available on macOS 13.0 or newer [-Werror,-Wunguarded-availability-new]
[task 2023-09-20T19:13:07.173Z]    76 |           kCGDisplayStreamShowCursor,       kCGDisplayStreamPreserveAspectRatio,
[task 2023-09-20T19:13:07.173Z]       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-09-20T19:13:07.173Z] ../../../../../fetches/MacOSX13.3.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGDisplayStream.h:195:30: note: 'kCGDisplayStreamShowCursor' has been marked as being introduced in macOS 13.0 here, but the deployment target is macOS 10.15.0
[task 2023-09-20T19:13:07.173Z]   195 | CG_EXTERN const CFStringRef  kCGDisplayStreamShowCursor CG_AVAILABLE_BUT_DEPRECATED(13.0, 14.0, "Please use ScreenCaptureKit API's SCStreamConfiguration showsCursor property instead");  /* CFBoolean - defaults to false */
[task 2023-09-20T19:13:07.173Z]       |                              ^
[task 2023-09-20T19:13:07.173Z] ../../content/browser/media/capture/desktop_capture_device_mac.cc:76:11: note: enclose 'kCGDisplayStreamShowCursor' in a __builtin_available check to silence this warning
[task 2023-09-20T19:13:07.173Z]    75 |       const void* keys[kNumKeys] = {
[task 2023-09-20T19:13:07.173Z]    76 |           kCGDisplayStreamShowCursor,       kCGDisplayStreamPreserveAspectRatio,
[task 2023-09-20T19:13:07.173Z]       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-09-20T19:13:07.173Z]    77 |           kCGDisplayStreamMinimumFrameTime, kCGDisplayStreamColorSpace,
[task 2023-09-20T19:13:07.173Z]    78 |           kCGDisplayStreamDestinationRect,
[task 2023-09-20T19:13:07.173Z]    79 |       };
[task 2023-09-20T19:13:07.173Z]    80 |       const void* values[kNumKeys] = {
[task 2023-09-20T19:13:07.173Z]    81 |           kCFBooleanTrue,
[task 2023-09-20T19:13:07.173Z]    82 |           kCFBooleanFalse,
[task 2023-09-20T19:13:07.173Z]    83 |           cf_max_frame_time.get(),
[task 2023-09-20T19:13:07.173Z]    84 |           cg_color_space.get(),
[task 2023-09-20T19:13:07.173Z]    85 |           dest_rect_in_frame_dict.get(),
[task 2023-09-20T19:13:07.173Z]    86 |       };
[task 2023-09-20T19:13:07.173Z]    87 |       properties.reset(CFDictionaryCreate(
[task 2023-09-20T19:13:07.173Z]    88 |           kCFAllocatorDefault, keys, values, kNumKeys,
[task 2023-09-20T19:13:07.173Z]    89 |           &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
[task 2023-09-20T19:13:07.173Z]       |                                                                              
[task 2023-09-20T19:13:07.173Z] ../../content/browser/media/capture/desktop_capture_device_mac.cc:76:45: error: 'kCGDisplayStreamPreserveAspectRatio' is only available on macOS 13.0 or newer [-Werror,-Wunguarded-availability-new]
[task 2023-09-20T19:13:07.173Z]    76 |           kCGDisplayStreamShowCursor,       kCGDisplayStreamPreserveAspectRatio,
[task 2023-09-20T19:13:07.173Z]       |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-09-20T19:13:07.173Z] ../../../../../fetches/MacOSX13.3.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGDisplayStream.h:177:30: note: 'kCGDisplayStreamPreserveAspectRatio' has been marked as being introduced in macOS 13.0 here, but the deployment target is macOS 10.15.0
[task 2023-09-20T19:13:07.173Z]   177 | CG_EXTERN const CFStringRef  kCGDisplayStreamPreserveAspectRatio CG_AVAILABLE_BUT_DEPRECATED(13.0, 14.0, "Please use ScreenCaptureKit API's SCStreamConfiguration preserveAspectRatio property instead"); /* CFBoolean - defaults to true */
[task 2023-09-20T19:13:07.173Z]       |                              ^
[task 2023-09-20T19:13:07.173Z] ../../content/browser/media/capture/desktop_capture_device_mac.cc:76:45: note: enclose 'kCGDisplayStreamPreserveAspectRatio' in a __builtin_available check to silence this warning
[task 2023-09-20T19:13:07.174Z]    75 |       const void* keys[kNumKeys] = {
[task 2023-09-20T19:13:07.174Z]    76 |           kCGDisplayStreamShowCursor,       kCGDisplayStreamPreserveAspectRatio,
[task 2023-09-20T19:13:07.174Z]       |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-09-20T19:13:07.174Z]    77 |           kCGDisplayStreamMinimumFrameTime, kCGDisplayStreamColorSpace,
[task 2023-09-20T19:13:07.174Z]    78 |           kCGDisplayStreamDestinationRect,
[task 2023-09-20T19:13:07.174Z]    79 |       };
[task 2023-09-20T19:13:07.174Z]    80 |       const void* values[kNumKeys] = {
[task 2023-09-20T19:13:07.174Z]    81 |           kCFBooleanTrue,
[task 2023-09-20T19:13:07.174Z]    82 |           kCFBooleanFalse,
[task 2023-09-20T19:13:07.174Z]    83 |           cf_max_frame_time.get(),
[task 2023-09-20T19:13:07.174Z]    84 |           cg_color_space.get(),
[task 2023-09-20T19:13:07.174Z]    85 |           dest_rect_in_frame_dict.get(),
[task 2023-09-20T19:13:07.174Z]    86 |       };
[task 2023-09-20T19:13:07.174Z]    87 |       properties.reset(CFDictionaryCreate(
[task 2023-09-20T19:13:07.174Z]    88 |           kCFAllocatorDefault, keys, values, kNumKeys,
[task 2023-09-20T19:13:07.174Z]    89 |           &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
[task 2023-09-20T19:13:07.174Z]       |                                                                              
[task 2023-09-20T19:13:07.174Z] ../../content/browser/media/capture/desktop_capture_device_mac.cc:77:11: error: 'kCGDisplayStreamMinimumFrameTime' is only available on macOS 13.0 or newer [-Werror,-Wunguarded-availability-new]
[task 2023-09-20T19:13:07.174Z]    77 |           kCGDisplayStreamMinimumFrameTime, kCGDisplayStreamColorSpace,
[task 2023-09-20T19:13:07.174Z]       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-09-20T19:13:07.174Z] ../../../../../fetches/MacOSX13.3.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGDisplayStream.h:189:30: note: 'kCGDisplayStreamMinimumFrameTime' has been marked as being introduced in macOS 13.0 here, but the deployment target is macOS 10.15.0
[task 2023-09-20T19:13:07.174Z]   189 | CG_EXTERN const CFStringRef  kCGDisplayStreamMinimumFrameTime CG_AVAILABLE_BUT_DEPRECATED(13.0, 14.0, "Please use ScreenCaptureKit API's SCStreamConfiguration minimumFrameInterval property instead");    /* CFNumber in seconds, defaults to zero. */
[task 2023-09-20T19:13:07.174Z]       |                              ^
[task 2023-09-20T19:13:07.174Z] ../../content/browser/media/capture/desktop_capture_device_mac.cc:77:11: note: enclose 'kCGDisplayStreamMinimumFrameTime' in a __builtin_available check to silence this warning
[task 2023-09-20T19:13:07.174Z]    75 |       const void* keys[kNumKeys] = {
[task 2023-09-20T19:13:07.174Z]    76 |           kCGDisplayStreamShowCursor,       kCGDisplayStreamPreserveAspectRatio,
[task 2023-09-20T19:13:07.174Z]    77 |           kCGDisplayStreamMinimumFrameTime, kCGDisplayStreamColorSpace,
[task 2023-09-20T19:13:07.174Z]       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-09-20T19:13:07.174Z]    78 |           kCGDisplayStreamDestinationRect,
<...>

Hi Mike! Can you please take a look at this?
It seems to have started with this merge. Could this be something caused by Bug 1852202?
Thank you!

Flags: needinfo?(mh+mozilla)
Component: Toolchains → Raptor
Flags: needinfo?(mh+mozilla) → needinfo?(kshampur)
Product: Firefox Build System → Testing

Thanks for the ni? was looking into this earlier today when I noticed it failing.

I suspect it is because google updated their min sdk version from 13.3 to 14 yesterday
https://chromium.googlesource.com/chromium/src/+/9f86a2804108f82dcc1c42036025a18f72c7fb9e%5E%21/build/config/mac/mac_sdk.gni

i have a try running to see if overriding it with gclient config back to 13.3 helps

Otherwise I may look into adding a sdk 14.0 toolchain like in Bug 1833995 (probably the better option than an override)

keeping ni? for now

Okay looks like I needed to add a 14.0 sdk toolchain afterall. works with it https://treeherder.mozilla.org/jobs?repo=try&revision=6a2eac11971020e37aaf7d1251b1435ee0345953&selectedTaskRun=GZfOn8CjQCSwWi3TzTRBHA.0

I will file a bug and patch shortly

Assignee: nobody → kshampur
Status: NEW → ASSIGNED
Flags: needinfo?(kshampur)
Depends on: 1854635

Upstream chromium builds now use version 14.0 SDK for OSX builds.
Additionally, bump up the wait time as that has been steadily
increasing, but more so for OSX (bug 1846810 follows up on other
platforms and cron scheduling if needed)

Depends on D188980

Attachment #9354592 - Attachment description: WIP: Bug 1854267 - Update CaR OSX builds to use MacOSX14.0 sdk. r?#perftest → Bug 1854267 - Update CaR OSX builds to use MacOSX14.0 sdk. r?#perftest
Whiteboard: [fxp]
See Also: → 1854849
Pushed by kshampur@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6b39ea73d85 Update CaR OSX builds to use MacOSX14.0 sdk. r=perftest-reviewers,sparky
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: