1854305 - [clang 8] error: invalid capability name 'main thread'; capability name must be 'mutex' or 'role' [-Werror,-Wthread-safety-attributes]

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Mike Hommey [:glandium]]

[task 2023-09-21T04:42:28.422Z] 04:42:28    ERROR -  /builds/worker/workspace/obj-build/dist/include/MainThreadUtils.h:41:22: error: invalid capability name 'main thread'; capability name must be 'mutex' or 'role' [-Werror,-Wthread-safety-attributes]
[task 2023-09-21T04:42:28.422Z] 04:42:28     INFO -  class MOZ_CAPABILITY("main thread") MainThreadCapability final {};
[task 2023-09-21T04:42:28.422Z] 04:42:28     INFO -                       ^
[task 2023-09-21T04:42:28.422Z] 04:42:28     INFO -  1 error generated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1854305 - Don't enable thread safety annotations before clang 11.

Arbitrary capability names weren't allowed until clang 11, and while we
could probably make things somehow work with earlier versions of clang,
it's not that interesting, as long as we keep the thread safety analysis
running with newer versions of clang on our CI (which we obviously do).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ee2919433c1
Don't enable thread safety annotations before clang 11. r=nika

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9ee2919433c1