18544 - [mlk] nsGfxTextControlFrame::Reflow() clobbers mDisplayFrame

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Chris Waterson]

...which in turn leaks a StyleContextImpl, and probably lots of other stuff.
buster, looks like you touched it last, so I'm giving you the love! (I'd fix,
but am pretty clueless in the layout engine. Maybe just need to call destroy
frame or something?)

Comment 1

[Chris Waterson]

Attachment: proposed fix

Comment 2

[Chris Waterson]

well, ok, maybe this ain't so hard. the attached fix seems to work, and clears
up the leak of 7 StyleContextImpl's on a clean startup/shutdown. Yay! Lemme know
if you want me to check it in, and I'll close the bug.

Comment 3

[rubydoo123]

setting to m12

Comment 4

[buster]

go for it, mr. waterson.  thanks!  if for some reason that isn't the total
solution, assign this back to me and I'll take it from there.

Comment 5

[Chris Waterson]

fix checked in, r=buster

Comment 6

[cpratt]

buster, waterson - any idea on how to verify this fix? just check lxr for the
changes? thanks! - cpratt

Comment 7

[Chris Waterson]

not easy to black box verify.