185443 - Assertions about empty damageRect caused by nsTableFrame::Reflow

Status: RESOLVED INVALID

(Core :: Layout: Tables, defect, P2)

Description

[Daniel Bratell]

I get an assertion  "empty damage rect: update caller to avoid fcn call overhead"

caused by:

  if (reflowedChildren) {
    Invalidate(aPresContext, nsRect(0, 0, PR_MAX(mRect.width, aDesiredSize.width), 
                                          PR_MAX(mRect.height,
aDesiredSize.height)));
  }

at line 2166 in nsTableFrame.cpp.

Comment 1

[Daniel Bratell]

I get it when I load a bonsai checkin page. mRect is empty and both preferred
width and height are also 0.

Comment 2

[timeless]

Attachment: how about this?

Comment 3

[Bernd]

The patch is wallpapering over the real cause of this assertion, how can it
happen that those sizes have 0 values?

Comment 4

[timeless]

it tends to happen a few times when a i load news.google.com and also when i
load some yahoo.com page (maybe / ?). it might also happen when i load buglist.

Comment 5

[Martin Mokrejs]

I get the same message when starting current mozilla snapshot:

*** Chrome Registration of package: Checking for contents.rdf at
jar:resource:/chrome/messenger.jar!/content/messenger-region/
*** Chrome Registration of locale : Checking for contents.rdf at
jar:resource:/chrome/en-US.jar!/locale/en-US/messenger/
*** Chrome Registration of locale : Checking for contents.rdf at
jar:resource:/chrome/US.jar!/locale/US/messenger-region/
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsChromeRegistry.cpp,
line 3185
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsChromeRegistry.cpp,
line 3185
GFX: dpi=75 t2p=0.0526316 p2t=19 depth=24
WEBSHELL+ = 1
LoadPlugin()
/afs/.gsf.de/i386_linux24/usr/mozilla-1.6a-20031105/lib/mozilla-1.6a/plugins/libnullplugin.so
returned 8351640
GetMIMEDescription() returned "*:.*:All types"
WEBSHELL+ = 2
Note: verifyreflow is disabled
Note: styleverifytree is disabled
Note: frameverifytree is disabled
WEBSHELL+ = 3
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
Document http://www.mozilla.org/start/ loaded successfully
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
Document http://www.mozilla.org/releases/stable.html loaded successfully

Comment 6

[Martin Mokrejs]

If you prefer your own testcase, then go for Debug/Verification/DOM:

WEBSHELL+ = 6
WEBSHELL+ = 7
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
WARNING: empty damage rect: update caller to avoid fcn call overhead, file
nsFrame.cpp, line 2540
Document
http://mozilla.org/quality/browser/standards/javascript/tcmatrix/index.html
loaded successfully

Comment 7

[Bernd]

Martin, could you please create a reduced testcase
(http://www.mozilla.org/newlayout/bugathon.html) from these URL's?

Comment 8

[Bernd]

there is no call to this function anymore, please reopen if I am to stupid to use mxr with a  corresponding mxr url.

Comment 9

[Martin Mokrejs]

The test case from comment #6 is gone and so far I did not get any similar message from TRUNK build on linux after short browsing around.